CFElements: use isRun3Cfg for legacy support

Use ComponentFactory.isRun3Cfg to check if we are in legacy configurable mode. This is more general than configurableRun3Behavior and ensures that the same logic is used as in CompFactory.

Also remove the use of the __future__ module and cleanup cmake configuration.

added full-unit-tests label

This merge request affects 1 package:

• Control/AthenaCommon

This merge request affects 35 files. Since this is a long list, it will not be printed.

Adding @ssnyder as watcher

added Core master review-pending-level-1 labels

CI Result FAILURE

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make	N/A	N/A	N/A	N/A	N/A	N/A
required tests	N/A	N/A	N/A	N/A	N/A	N/A
optional tests	N/A	N/A	N/A	N/A	N/A	N/A

Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 49883]

Jenkins please retry a build

This merge request affects 1 package:

• Control/AthenaCommon

This merge request affects 35 files. Since this is a long list, it will not be printed.

Adding @ssnyder as watcher

CI Result FAILURE (hash d4e91487)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 49932]

removed review-pending-level-1 label

added review-user-action-required label

Jenkins please retry a build

This merge request affects 1 package:

• Control/AthenaCommon

This merge request affects 35 files. Since this is a long list, it will not be printed.

Adding @ssnyder as watcher

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash d4e91487)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 51901]

added review-user-action-required label and removed review-pending-level-1 label

The unit test is failing with some sequence not being configurable. Could you please investigate?

Kira (L1)

marked this merge request as draft

removed review-user-action-required label

changed target branch from master to 22.0

closed

reopened

removed master label

marked this merge request as ready

This merge request affects 2 packages:

• Control/AthenaCommon
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@ssnyder ,@bernius as watchers

added 22.0 Trigger TriggerMenu review-pending-level-1 labels

CI Result SUCCESS (hash 643f2c58)

	Athena	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 53357]

The code and this run of the CI look good to me. Should this have run a full unit-test though? L1

removed review-pending-level-1 label

added review-user-action-required label

removed review-user-action-required label

added review-pending-level-1 label

added review-approved-tier0 label

resolved all threads

Approved. L1

removed review-pending-level-1 label

added review-approved label

added review-approved-point1 label

mentioned in commit f8d076ce

merged