Add CA config for ACTS refit alg and add support for ITk

added ACTS ITk labels

added NewConfig label

Could you also think how to restructure the code moving algorithms and tools under ActsTrkTools and ActsTrkAlgs? Thank you!

Hi @pagessin ActsTrackingGeometryToolCfg (as well as ActsATLASConverterTool) is also called in Tracking/Acts/ActsTrkAlgs/ActsTrkSeeding/python/ActsTrkSeedingConfig.py. Can you update that file accordingly?

I updated this to use additional components for direction to angles and angle to direction conversion. However, I still get slight differences in global covariances between PC (ACTS) and XY (ATLAS), which I don't expect. I think as was the case for the local measurement conversion, this should be 1:1. I've attached some plots of l0, l1 of the parameter conversion ACTS->ATLAS.

I'm not entirely sure if this is sufficient for the downstream comparisons. If the covariance is off due to the conversion here, I don't know how much we can trust the track level residuals etc.

added 2433 commits

• 9ef1df6d...9fb366c7 - 2419 commits from branch atlas:master
• c79985a7 - first draft of refitting CA config
• 21e31786 - minor fixes
• cde628f0 - wip for testing cov conversion
• 61683c05 - xy2pc only (fails)
• 01847bbf - config fix/ update
• 5177592e - method 2?
• e9f37111 - checkpoint
• 544cc328 - cluster INTO acts almost works
• 4927e0e5 - very WIP
• e1c2ac42 - conversion back works
• a7f1dc3b - remove some parts
• 76c4bfe9 - some more cleanup
• 66d38650 - updates to configuration and cov conversion
• bc4af259 - fix another broken config

Compare with previous version

added 388 commits

• bc4af259...9af24fb6 - 373 commits from branch atlas:master
• 72d30a52 - first draft of refitting CA config
• d39ba814 - minor fixes
• a9ccbad1 - wip for testing cov conversion
• 893c7b2b - xy2pc only (fails)
• bf8801b5 - config fix/ update
• 2a4cbd42 - method 2?
• bb0c308a - checkpoint
• 01b9c8bb - cluster INTO acts almost works
• e7823a1f - very WIP
• 0fb54b08 - conversion back works
• 92ae86d4 - remove some parts
• e11a69ad - some more cleanup
• 2e1a3082 - updates to configuration and cov conversion
• 067837d7 - fix another broken config
• 4a23402b - move ActsTrkFitting into two packages under ActsTrkAlgs and ActsTrkTools

Compare with previous version

Hey @cvarni, @ncalace (and @corentin maybe?): I fixed the remaining broken configuration uses that I could find, and split up ActsTrkFitting into two new packages.

Let me know if there's other changes at this point, otherwise I'll undraft this and start CI / review.

Looks good to me! Thank you!

marked this merge request as ready

only a few additional comments from my side from a quick look at it. The only really relevant is the ActsATLASConverterToolCfg

This merge request affects 7 packages:

• InnerDetector/InDetConfig
• Tracking/Acts/ActsGeometry
• Tracking/Acts/ActsGeometryInterfaces
• Tracking/Acts/ActsTrkAlgs/ActsTrkFittingAlgs
• Tracking/Acts/ActsTrkAlgs/ActsTrkSeeding
• Tracking/Acts/ActsTrkFitting
• Tracking/Acts/ActsTrkTools/ActsTrkFittingTools

Affected files list will not be printed in this case

Adding @goetz ,@amorley ,@cvarni ,@sroe ,@pagessin as watchers

added InnerDetector Tracking master review-pending-level-1 labels

CI Result SUCCESS (hash 4a23402b)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 52126]

added 1 commit

• 67f0b681 - add debug output flag, config + copyright update

Compare with previous version

This merge request affects 7 packages:

• InnerDetector/InDetConfig
• Tracking/Acts/ActsGeometry
• Tracking/Acts/ActsGeometryInterfaces
• Tracking/Acts/ActsTrkAlgs/ActsTrkFittingAlgs
• Tracking/Acts/ActsTrkAlgs/ActsTrkSeeding
• Tracking/Acts/ActsTrkFitting
• Tracking/Acts/ActsTrkTools/ActsTrkFittingTools

Affected files list will not be printed in this case

Adding @goetz ,@amorley ,@cvarni ,@sroe ,@pagessin as watchers

CI Result SUCCESS (hash 67f0b681)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 52222]

resolved all threads

MR looks good to me, all comments have been addressed and CI was passed. Approving.

Cheers, Martin (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit ec333b08

added sweep:ignore label