Skip to content
Snippets Groups Projects

Extended prd info writing for CA tracking config

Merged Thomas Strebler requested to merge tstreble/athena:ExtendedPRDInfo into master
All threads resolved!

This MR enables the writing of some extended cluster information, similar to what was available in the DAOD_IDTRKVALID format in the legacy config. This behavior is controlled by a new flag InDet.Tracking.writeExtendedPRDInfo and is expected to be used only for local processings initially. Both the ID and ITk configs are updated, with information saved for all subdetectors.

This will be in particular needed to derive new ITk pixel analogue clustering constants in master. A subsequent MR will be set up to add new decoration variables needed for that specific purpose.

FYI @pagessin @lgagnon @npetters @tadej

Edited by Thomas Strebler

Merge request reports

Pipeline #3875472 passed

Pipeline passed for 4d87651c on tstreble:ExtendedPRDInfo

Approval is optional

Merged by Johannes ElmsheuserJohannes Elmsheuser 2 years ago (Apr 22, 2022 2:24pm UTC)

Merge details

  • Changes merged into master with 2e1edc14 (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Just a few remarks. Looks good so far, but I cannot judge the cmake change. L1

  • Thomas Strebler added 2 commits

    added 2 commits

    • d4ae6ba9 - Dummy initialisation of m_doIBL
    • 4d87651c - Fix typo in ReadCondHandleKey for PixelPrepDataToxAOD

    Compare with previous version

  • This merge request affects 5 packages:

    • InnerDetector/InDetCalibAlgs/PixelCalibAlgs
    • InnerDetector/InDetConfig
    • InnerDetector/InDetEventCnv/InDetPrepRawDataToxAOD
    • InnerDetector/InDetValidation/InDetPhysValMonitoring
    • Tracking/TrkConfig

    Affected files list will not be printed in this case

    Adding @goetz ,@amorley ,@battagl ,@sroe ,@stsuno ,@lshan as watchers

  • :white_check_mark: CI Result SUCCESS (hash 4d87651c)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 50774]

  • Thomas Strebler resolved all threads

    resolved all threads

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit 2e1edc14

  • Thomas Strebler mentioned in merge request !52505 (merged)

    mentioned in merge request !52505 (merged)

  • Thomas Strebler mentioned in merge request !52840 (merged)

    mentioned in merge request !52840 (merged)

  • Please register or sign in to reply
    Loading