Skip to content
Snippets Groups Projects

add tot protection (ATLASSIM-5777)

Merged add tot protection (ATLASSIM-5777)
stsuno/athena:atlassim-5777 into master
All threads resolved!
Merged Soshi Tsuno requested to merge stsuno/athena:atlassim-5777 into master
All threads resolved!

Adding the tot protection of the noise simulation.

Merge request reports

Pipeline #3872808 passed

Stage: external

    Pipeline passed for 1cf9d135 on stsuno:atlassim-5777

    Approval is optional

    Merged by Johannes ElmsheuserJohannes Elmsheuser 2 years ago (Apr 21, 2022 8:37am UTC)

    Merge details

    • Changes merged into master with 451bf309 (commits were squashed).
    • Deleted the source branch.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Shaun Roe
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 628c2c30)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 50617]

  • S
    Sergei Rosliakov @seroslia1 ·

    Hi @stsuno, please resolve all open threads and relabel

    Sergei L1

  • Sergei Rosliakov added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Soshi Tsuno added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • InnerDetector/InDetDigitization/PixelDigitization

    This merge request affects 1 file:

    • InnerDetector/InDetDigitization/PixelDigitization/src/FrontEndSimTool.h

    Adding @jchapman ,@goetz ,@stsuno ,@lshan ,@battagl ,@sroe as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • Soshi Tsuno resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 9f7f7cd9)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :warning: :warning: :warning: :white_check_mark: :warning: :warning:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 50661]

  • Carlo Varni
  • Carlo Varni added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Soshi Tsuno added 194 commits

    added 194 commits

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • InnerDetector/InDetDigitization/PixelDigitization

    This merge request affects 1 file:

    • InnerDetector/InDetDigitization/PixelDigitization/src/FrontEndSimTool.h

    Adding @jchapman ,@goetz ,@stsuno ,@lshan ,@battagl ,@sroe as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 1cf9d135)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 50737]

  • Soshi Tsuno resolved all threads

    resolved all threads

  • John Derek Chapman
    John Derek Chapman @jchapman ·
    Owner

    Hi @elmsheus,

    Can this one be merged today please? We need it for the next round of digitization/overlay tests.

    Cheers,

    John

  • Johannes Elmsheuser
    Johannes Elmsheuser @elmsheus ·
    Maintainer

    Looks good - Approving.

    Johannes (RC)

  • Johannes Elmsheuser added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Johannes Elmsheuser mentioned in commit 451bf309

    mentioned in commit 451bf309

  • Johannes Elmsheuser merged

    merged

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply