Skip to content
Snippets Groups Projects

Use centralised sp converter

Merged Carlo Varni requested to merge cvarni/athena:UseCentralisedSPConverter into master
All threads resolved!

Removing the (temporary) space point formation functionality from the Seeding Algorithm that process Athena-like objects. That piece of code was necessary before due to the lack of a space point formation algorithm which is now available.

Tagging @tbold and @ncalace FYI

Edited by Carlo Varni

Merge request reports

Pipeline #3867263 passed

Pipeline passed for 063c2603 on cvarni:UseCentralisedSPConverter

Approval is optional

Merged by Johannes ElmsheuserJohannes Elmsheuser 2 years ago (Apr 21, 2022 9:42am UTC)

Merge details

  • Changes merged into master with 2901c562 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Carlo Varni resolved all threads

    resolved all threads

  • Joana Niermann resolved all threads

    resolved all threads

  • Approving now after thread was resolved. L1

  • mentioned in commit 2901c562

  • Please register or sign in to reply
    Loading