Skip to content
Snippets Groups Projects

Externals Update and Warning Hack Removals, master branch (2022.04.25.)

Merged Externals Update and Warning Hack Removals, master branch (2022.04.25.)
akraszna/athena:ExternalsUpdate-master-20220425 into master
Merged Attila Krasznahorkay requested to merge akraszna/athena:ExternalsUpdate-master-20220425 into master

Upgraded all projects to atlasexternals-2.0.132. The changes wrt. atlasexternals-2.0.130 are (atlasexternals@2.0.130...2.0.132):

  • Updated atlas_add_executable(...) to declare external include paths as SYSTEM includes;
  • Updated atlas_add_dictionary(...) to declare external include paths (as well as ROOT's include path) as SYSTEM includes.

They are both meant for ATEAM-826.

While at it, I removed the usage of all CxxUtils "warning headers". And since I bumped into them, I also removed some Boost warning suppression code from HDF5Utils. @ssnyder, I still see a good number of "clang pragmas" in the code. We could probably remove a few more after this has gone in. Also, since no piece of code uses the CxxUtils.*warning.h headers anymore after this MR, I would also vote for removing those in a future MR.

Note that GCC never issued warnings for these in the first place, so the CI will be completely oblivious to these changes. But hand-on-heart, I tested that the warnings are gone with Clang 14 after these updates.

Finally, once this is in, !52385 (closed) is free to be merged in. (Pinging @sutt about that.)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply