Fix the sTGC place holder time-to-tdo calibration

The "place holder" calibration shifts digit time by a value, which is set to 100 ns, so that time becomes positive in order to avoid FPE warnings when writing RDOs to the disk, since the time variable in the persistent RDO class is an unsigned integer. The value of the shift has to correspond to the smallest time considered for digitization, which is defined at Line12 in sTGC_Digitization/python/sTGC_DigitizationConfig.py. This "place holder" calibration will be replaced by a proper calibration interface that is currently under development.

marked this merge request as draft

This merge request affects 1 package:

• MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest

This merge request affects 2 files:

• MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest/src/STGC_DigitToRDO.cxx
• MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest/src/STGC_RdoToDigit.cxx

Adding @rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers

added MuonSpectrometer master review-pending-level-1 labels

added 1 commit

• 24058ac0 - Set a same value to STGC RDO time variables

Compare with previous version

marked this merge request as ready

CI Result SUCCESS (hash a738e4fd)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 51189]

This merge request affects 2 packages:

• MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest
• MuonSpectrometer/MuonCnv/MuonEventTPCnv

Affected files list will not be printed in this case

Adding @rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers

CI Result SUCCESS (hash 24058ac0)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 51211]

Changes look good from L1 side - approving.

Jakub (L1 shifter)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit eeeccfdc

added sweep:ignore label

mentioned in merge request !52873 (merged)

mentioned in merge request !52947 (closed)