Fix and prevent irreproducible ordering of Trigger EDM list
Trigger configuration must be completely reproducible, including ordering of all job properties. One of the properties is built from the Run-3 Trigger EDM list which recently introduced an irreproducibility by using list(set(something))
in !52412 (merged). Fix this issue by sorting this list, and add a unit test to prevent such bugs in the future.
The new unit test runs in 6 seconds on my laptop.
Fixes ATR-25096
Merge request reports
Activity
This merge request affects 1 package:
- Trigger/TriggerCommon/TrigEDMConfig
This merge request affects 4 files:
- Trigger/TriggerCommon/TrigEDMConfig/CMakeLists.txt
- Trigger/TriggerCommon/TrigEDMConfig/python/TriggerEDMRun3.py
- Trigger/TriggerCommon/TrigEDMConfig/python/testEDMRun3.py
- Trigger/TriggerCommon/TrigEDMConfig/test/testTriggerEDMRun3Reproducibility.sh
added Trigger TriggerEDM master review-pending-level-1 labels
CI Result SUCCESS (hash 1194864c)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 51381]- Resolved by Dan Guest
added review-approved label and removed review-pending-level-1 label
mentioned in commit 82677ed0
added sweep:ignore label