Skip to content
Snippets Groups Projects

Fix and prevent irreproducible ordering of Trigger EDM list

Merged Rafal Bielski requested to merge rbielski/athena:trig-edm-ordering into master
All threads resolved!

Trigger configuration must be completely reproducible, including ordering of all job properties. One of the properties is built from the Run-3 Trigger EDM list which recently introduced an irreproducibility by using list(set(something)) in !52412 (merged). Fix this issue by sorting this list, and add a unit test to prevent such bugs in the future.

The new unit test runs in 6 seconds on my laptop.

Fixes ATR-25096

Merge request reports

Pipeline #3918089 passed

Pipeline passed for 1194864c on rbielski:trig-edm-ordering

Approval is optional

Merged by Walter LamplWalter Lampl 2 years ago (May 3, 2022 7:18am UTC)

Merge details

  • Changes merged into master with 82677ed0 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Dan Guest resolved all threads

    resolved all threads

  • Changes look fine to me, approving.

    Cheers, Martin (L1)

  • merged

  • Walter Lampl mentioned in commit 82677ed0

    mentioned in commit 82677ed0

  • Please register or sign in to reply
    Loading