Replace sTGC time-tdo constant with static variable

Similar changes to MR !52717 (merged), because it was found that the shift value of the "place holder" time-TDO conversion wasn't sufficient due to a Gaussian smearing. Also the changes fix the FPE warnings reported in ATR-25352. A proper NSW calibration is under development, and will replace the place holder time-TDO conversion. However, the calibration might not work in RDO transient-persistent converters. So this place holder would be used in MuonRDO/STGC_RawDataCnv_p1.cxx to preserve backward compatibility, though there is not a single realistic case where the _p1 version is needed now or in the future.

marked this merge request as ready

This merge request affects 3 packages:

• MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest
• MuonSpectrometer/MuonCnv/MuonEventTPCnv
• MuonSpectrometer/MuonRDO

Affected files list will not be printed in this case

Adding @rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers

added MuonSpectrometer master review-pending-level-1 labels

CI Result SUCCESS (hash fc63b1cc)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 51554]

Changes look good from L1 side - approving.

Jakub (L1 shifter)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit d9a54589

added sweep:ignore label

mentioned in merge request !52947 (closed)