Skip to content
Snippets Groups Projects

NSW Simulation - MM fixes and adjustments

Merged NSW Simulation - MM fixes and adjustments
fgravili/athena:cleanup into master
All threads resolved!
Merged Francesco Giuseppe Gravili requested to merge fgravili/athena:cleanup into master
All threads resolved!

Cumulative MR to fix a few things (mainly the first bullet) and to adjust other ones on the MM side:

  • Fixed the way how RDO segments are built, making the procedure only if the input is in the allowed ranges
  • Moved all the include instances in the header file for the MMTriggerTool class
  • Changed to the default destructor for the same class
  • Values passed by reference in the TriggerProcessorTool class, avoiding the copy operation
  • Removed all the using instances and used the std:: namespace where needed
  • Big cleanup of empty and not used branches

./cc @iodice @rosati @vadamico

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Walter LamplWalter Lampl 2 years ago (May 6, 2022 9:26am UTC)

Merge details

  • Changes merged into master with 06678efd (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thomas Strebler
  • Thomas Strebler
    Thomas Strebler @tstreble ·
    Developer

    A code quality comment + copyrights to be updated. Otherwise looks good.

    --L1

  • Thomas Strebler added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Francesco Giuseppe Gravili added 2 commits

    added 2 commits

    • e3517b22 - Updated copyright
    • c6b14c1a - Removed forward declarations as includes are already in the header file

    Compare with previous version

  • Francesco Giuseppe Gravili resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Trigger/TrigT1/TrigT1NSWSimTools

    This merge request affects 7 files:

    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/MMLoadVariables.h
    • Trigger/TrigT1/TrigT1NSWSimTools/TrigT1NSWSimTools/MMTriggerTool.h
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMLoadVariables.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMTriggerTool.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/MMTriggerToolTree.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/StripClusterTool.cxx
    • Trigger/TrigT1/TrigT1NSWSimTools/src/TriggerProcessorTool.cxx

    Adding @afaulkne as watcher

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :scissors: The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash c6b14c1a)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 51613]

  • Kira Abeling added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Kira Abeling
    Kira Abeling @kiabelin ·
    Developer

    Comments have been addressed and CI looks fine. No further comments from my side. Approving.

    Kira (L1)

  • Walter Lampl merged

    merged

  • Walter Lampl mentioned in commit 06678efd

    mentioned in commit 06678efd

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply