NSW RDO data time window for pileup

Applying a time cut in the Digit->RDO conversion to emulate the same time window used for data. In the case of the MM, the data ranges 8BC, which for current digitization conditions is the range of time = [200, 400]ns. For sTGCs, the data ranges 8BC with the relative point being 12.5ns in BC0, resulting in t = [-87.5, 112.5]ns.

Applying this time cut at these stages allow for proper pileup simulation, while reducing the size of the RDO files and makes sure that the different algorithms downstream from digitization uses the correct time windows.

Before merging, it's probably best to receive approval from the sTGC and MM simulation responsibles. @chchau @pscholer @rosati

added Digitization MuonSpectrometer master labels

This merge request affects 1 package:

• MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest

This merge request affects 2 files:

• MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest/src/MM_DigitToRDO.cxx
• MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest/src/STGC_DigitToRDO.cxx

Adding @rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers

added review-pending-level-1 label

The time limits are the same as the ones in the calibration services, so they should be retrieved from the calibration services as Alexandre says. For the sTGC, both the place suggested here (DigitToRdo) and the sTGC digitization tool should have access to the calibration services when the calibration will be merged into master. So either place is fine. However, applying the cuts in DigitToRdo means they are next to the time-TDO conversion where the calibration enforces the 8BC limit.

CI Result SUCCESS (hash b002498c)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 51914]

added review-user-action-required label and removed review-pending-level-1 label

Changes and CI look fine from L1 point of view. The copyright is outdated in MM_DigitToRDO so if you do any other updates please consider also updating the copyright. Will move to user acton required until threads are resolved.

Kira (L1)

mentioned in merge request !53127 (merged)

removed review-user-action-required label

resolved all threads

added review-approved label

Adding review-approved as muon SW expert.

mentioned in commit b7b2e1a0

merged

added sweep:ignore label

mentioned in merge request !53151 (merged)

mentioned in merge request !52947 (closed)