InnerDetector: Sweep changes for strip endcap polar co-ordinates from 21.9

This is a manual sweep of the changes from !46959 (merged).

A bug fix with the order of co-ordinates in DetectorDescription/ReadoutGeometryBase/src/SolidStateDetectorElementBase.cxx was also made.

Standard tests RunUpgradeTests.log were run with all tests passing. There were a number of warnings, mostly concerning geometry differences, BTag and TruthParticleAuxContainers.

DCube plots comparing the outputs in the cartesian and polar case vs an unmodified version of Athena are available at [cartesian plots] and [polar plots]. The cartesian plots are identical; the polar plots have differences for ITkStrip/m_h_globalX, ITkStrip/m_h_globalY, and ITkStrip/m_h_globalXY.

I can't see any systematic difference here, more like a constant noise term. I'll investigate these numbers and where the difference comes from.

However, this is only in the polar case, which is never used unless a flag is manually added to the ITk Layouts, so this will not affect any existing workflows. Therefore I'd like to move forward with this MR.

This is part of ATLITKSW-42.

Tags: @nstyles @hhayward @tadej @pagessin

added Geometry ITk Tracking Upgrade bugfix master sweep:ignore labels

changed the description

changed the description

added 1150 commits

• 90dd2eb8...ae985715 - 1147 commits from branch atlas:master
• 480e6100 - Add strip frame <--> beam frame conversions from 21.9
• 60742ae1 - Swept changes to use PC
• 4899f8ba - Fix bug in hitLocalToLocal specialisation

Compare with previous version

marked this merge request as ready

This merge request affects 2 packages:

• DetectorDescription/ReadoutGeometryBase
• InnerDetector/InDetDetDescr/SCT_ReadoutGeometry

Affected files list will not be printed in this case

Adding @goetz ,@stavrop ,@sroe ,@rbianchi ,@jojungge as watchers

added HGTD InnerDetector review-pending-level-1 labels

CI Result SUCCESS (hash 4899f8ba)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 53047]

added review-user-action-required label and removed review-pending-level-1 label

Changing labels while the open thread is unresolved. As an additional comment, many introduced variables could be named such to respect ATLAS recommended naming conventions. See: http://atlas-computing.web.cern.ch/atlas-computing/projects/qa/draft_guidelines.html#org720328f

Anyway being this a sweep is probably not worth doing it here. Otherwise changes look good.

Sergio (L2)

resolved all threads

added 1179 commits

• 4899f8ba...f30174db - 1175 commits from branch atlas:master
• 693c1a8e - Add strip frame <--> beam frame conversions from 21.9
• e5cca0ed - Swept changes to use PC
• 9484484b - Fix bug in hitLocalToLocal specialisation
• af7e2c71 - Add comments explaining co-ordinate flips

Compare with previous version

Rebased and added some comments. Will let CI run then should be good to merge.

This merge request affects 2 packages:

• DetectorDescription/ReadoutGeometryBase
• InnerDetector/InDetDetDescr/SCT_ReadoutGeometry

Affected files list will not be printed in this case

Adding @goetz ,@stavrop ,@sroe ,@rbianchi ,@jojungge as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash af7e2c71)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 54228]

added review-user-action-required label and removed review-pending-level-1 label

I know this is a sweep but if it's not too much work it would be great if the two minor points could be addressed.

Kira (L1)

added 1 commit

• de98a8c2 - Added some std:: to math functions

Compare with previous version

resolved all threads

This merge request affects 2 packages:

• DetectorDescription/ReadoutGeometryBase
• InnerDetector/InDetDetDescr/SCT_ReadoutGeometry

Affected files list will not be printed in this case

Adding @goetz ,@stavrop ,@sroe ,@rbianchi ,@jojungge as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash de98a8c2)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 54294]

Looks good. Approved

Sergei L1

added review-approved label and removed review-pending-level-1 label

mentioned in commit e7a20225

merged