A bug fix with the order of co-ordinates in DetectorDescription/ReadoutGeometryBase/src/SolidStateDetectorElementBase.cxx was also made.
Standard tests RunUpgradeTests.log were run with all tests passing. There were a number of warnings, mostly concerning geometry differences, BTag and TruthParticleAuxContainers.
DCube plots comparing the outputs in the cartesian and polar case vs an unmodified version of Athena are available at [cartesian plots] and [polar plots]. The cartesian plots are identical; the polar plots have differences for ITkStrip/m_h_globalX, ITkStrip/m_h_globalY, and ITkStrip/m_h_globalXY.
I can't see any systematic difference here, more like a constant noise term. I'll investigate these numbers and where the difference comes from.
However, this is only in the polar case, which is never used unless a flag is manually added to the ITk Layouts, so this will not affect any existing workflows. Therefore I'd like to move forward with this MR.
