fix peak in MM overlay time spectrum

The main goal of this merge request is to overcome the overlay timing issues in the MM. The following things have been done:

• Add proper protection in case the VMM simulation finds a peak outside the timing window which otherwise lead to the use of 0 ns to which variables were initialized to.
• Add a property to explicitly set the deadtime of the VMM, e.g. how much time before the actual time window should be processed by the VMM simulation
• Add an upper graze time window to the VMM simulation. This is needed since the code produced a peak in the time spectrum at the upper boundary of the time window. This behavior is not yet understood but ommited by simulating longer (the graze time) and then cutting on the actual time window afterwards.
• Since the time window is now implemented into the digitization the initial hack of the MM_DigitToRDO applied in !53117 (merged) is removed again.

@alaurier @rosati @jojungge

added 1 commit

• ecff0878 - implement timing cuts for overlay into MM electronics simulation

Compare with previous version

Jenkins please retry a build

Hi @alaurier I have put all the timing cuts for the MMs into the electronics response simulation now which is part of the digitization. It would be amazing if you could also check the output when running with this second commit. Thanks! Patrick

This merge request affects 1 package:

• MuonSpectrometer/MuonDigitization/MM_Digitization

This merge request affects 6 files:

• MuonSpectrometer/MuonDigitization/MM_Digitization/MM_Digitization/MM_DigitizationTool.h
• MuonSpectrometer/MuonDigitization/MM_Digitization/MM_Digitization/MM_ElectronicsResponseSimulation.h
• MuonSpectrometer/MuonDigitization/MM_Digitization/MM_Digitization/VMM_Shaper.h
• MuonSpectrometer/MuonDigitization/MM_Digitization/src/MM_DigitizationTool.cxx
• MuonSpectrometer/MuonDigitization/MM_Digitization/src/MM_ElectronicsResponseSimulation.cxx
• MuonSpectrometer/MuonDigitization/MM_Digitization/src/VMM_Shaper.cxx

Adding @jchapman ,@rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers

added Digitization MuonSpectrometer master labels

CI Result SUCCESS (hash ecff0878)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 51997]

Hi @pscholer , I have performed the validation throughout the day and evening. I find that this MR needs one modification, changing m_timeWindowLowerOffset from -300 to 0, in order to fix all the issues I identified.

My recommendation is that we use the changes in this MR, add a commit reverting todays changes to MM_DigitToRdo in !53117 (merged), and make sure we update the copyrights to 2022 (I told a shifter we would do it in this MR!).

This will fix the problematic timing distributions in MM pileup.

My most recent tests show that the combination of all the MRs I implemented this week (plus this one) fixes all the MM pileup timing distribution issues, MM Identifier warnings in digitization, and the MM related FPE warnings in the L1 trigger simulation tests. After this MR is merged, and with approval from other experts, I will close my draft MR which introduced the MM timing issues. !52947 (closed)

added 149 commits

• ecff0878...1cf0ef15 - 146 commits from branch atlas:master
• dfabd781 - update lower boundary of time window to 0 ns
• 05d65827 - Merge branch 'master' of https://gitlab.cern.ch:8443/atlas/athena into fixVMMSim
• 1d4d077d - undo timing cut in the MM_DigitToRDO converter

Compare with previous version

marked this merge request as ready

This merge request affects 2 packages:

• MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest
• MuonSpectrometer/MuonDigitization/MM_Digitization

Affected files list will not be printed in this case

Adding @jchapman ,@rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers

added review-pending-level-1 label

changed the description

resolved all threads

CI Result SUCCESS (hash 1d4d077d)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 52026]

added urgent label

Adding the urgent label since this cruccial fix of the MM overlay timing should go in today if possible. Tagging @tlari

The latest commits from today look good. Thanks @pscholer

added review-approved label and removed review-pending-level-1 label

mentioned in merge request !52947 (closed)

merged