sTGC Strip Trigger: Fixed the scattered point segment finding inefficiencies
There are some scattered point inefficiencies for the strip trigger performance, due to some trigger candidates are missed, such as:
-
In the stripSegmentTool, the hash_bandid originally couldn't distinguish '1'+'72' and '17' + '2', hence the charge centroids in 2 sides only form 1 segment, causing one muon's efficiency lost with dimu samples
-
In the stripClusterTool, the judgement statement for the first time will miss the case if the first several digits with the same channelId but belonging to different bcs (the strategy allows +-1 bc now)
-
The dtheta < 15 mrad sentence caused the loop finished prematurely, resulting in the efficiency in A side get lower by 5% compared to the one of C side, fix it, and adjust its position for a more flexible performance study, without effecting the record for the later trigger logics
Before/After these changes:
Merge request reports
Activity
This merge request affects 1 package:
- Trigger/TrigT1/TrigT1NSWSimTools
This merge request affects 2 files:
- Trigger/TrigT1/TrigT1NSWSimTools/src/StripClusterTool.cxx
- Trigger/TrigT1/TrigT1NSWSimTools/src/StripSegmentTool.cxx
Adding @afaulkne as watcher
added Trigger master review-pending-level-1 labels
removed Trigger master review-pending-level-1 labels
CI Result SUCCESS (hash ce8a4062)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 52202]added 181 commits
-
ce8a4062...bcfffaf8 - 180 commits from branch
atlas:master
- fcf89db3 - Merge branch 'master' into 'yi_stripsegment'
-
ce8a4062...bcfffaf8 - 180 commits from branch
This merge request affects 1 package:
- Trigger/TrigT1/TrigT1NSWSimTools
This merge request affects 2 files:
- Trigger/TrigT1/TrigT1NSWSimTools/src/StripClusterTool.cxx
- Trigger/TrigT1/TrigT1NSWSimTools/src/StripSegmentTool.cxx
Adding @afaulkne as watcher
added Trigger master review-pending-level-1 labels
This merge request affects 1 package:
- Trigger/TrigT1/TrigT1NSWSimTools
This merge request affects 2 files:
- Trigger/TrigT1/TrigT1NSWSimTools/src/StripClusterTool.cxx
- Trigger/TrigT1/TrigT1NSWSimTools/src/StripSegmentTool.cxx
Adding @afaulkne as watcher
CI Result SUCCESS (hash fcf89db3)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 52310] CI Result SUCCESS (hash a5d46af1)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 52313]removed review-pending-level-1 label