Skip to content
Snippets Groups Projects

Add Btagging and additional variable to HIGG1D1

Merged Anthony Morley requested to merge amorley/athena:UpdateHigg1D1_2 into master
All threads resolved!

Corrects the calibration sequence for jets in Higg1D1, Adds b-tagging and a number of e/gamma decorations to egammna objects in the HIGG1D1 derivation.

Merge request reports

Pipeline #4007023 passed

Pipeline passed for 3686a73b on amorley:UpdateHigg1D1_2

Approval is optional

Merged by Adam Edward BartonAdam Edward Barton 2 years ago (May 24, 2022 8:52am UTC)

Merge details

  • Changes merged into master with dcfc5ea4 (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Kira Abeling
  • Only two minor comments regarding print statements from L1 point of view. Passing on to L2 in the meantime for a cross check. It would also be good to have a sign off from the HIGG derivation contacts but I didn't find who's responsible.

    Kira (L1)

    Edited by Kira Abeling
  • Anthony Morley added 1 commit

    added 1 commit

    • 3686a73b - Remove debugging print statements and add a small comment

    Compare with previous version

  • This merge request affects 4 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkCalo
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkHiggs
    • Reconstruction/Jet/JetCalibTools
    • Reconstruction/Jet/JetMomentTools

    Affected files list will not be printed in this case

    Adding @goetz ,@dshope ,@mdaneri ,@mleblanc as watchers

  • Kira Abeling resolved all threads

    resolved all threads

  • Putting L2 label back as before because L1 comments have been adressed.

    Kira (L1)

  • Jenkins please retry a build

  • Job restarted after the intervention for a Java version update

  • This merge request affects 4 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkCalo
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkHiggs
    • Reconstruction/Jet/JetCalibTools
    • Reconstruction/Jet/JetMomentTools

    Affected files list will not be printed in this case

    Adding @goetz ,@dshope ,@mdaneri ,@mleblanc as watchers

  • :white_check_mark: CI Result SUCCESS (hash 3686a73b)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 52838]

  • Once again passing to L2 shifter after CI re-run.

    Jakub (L1 shifter)

  • Looks good, approving.

    Sergio (L2)

  • mentioned in commit dcfc5ea4

  • Please register or sign in to reply
    Loading