PanTauAlgs minor fixes

Hello,

This MR is improving a few things: pass by reference instead of value, drop const_cast (the easy ones, there are still some to be removed), make code a bit more readable. The reconstruction output is unchanged. Targets 22.0 as the goal is ultimately to make the corresponding algorithm re-entrant for Run3 reco.

Cheers, Bertrand

This merge request affects 1 package:

• Reconstruction/PanTau/PanTauAlgs

This merge request affects 7 files:

• Reconstruction/PanTau/PanTauAlgs/PanTauAlgs/PanTauSeed.h
• Reconstruction/PanTau/PanTauAlgs/PanTauAlgs/TauConstituent.h
• Reconstruction/PanTau/PanTauAlgs/PanTauAlgs/Tool_DetailsArranger.h
• Reconstruction/PanTau/PanTauAlgs/PanTauAlgs/Tool_FeatureExtractor.h
• Reconstruction/PanTau/PanTauAlgs/Root/TauConstituent.cxx
• Reconstruction/PanTau/PanTauAlgs/Root/Tool_DetailsArranger.cxx
• Reconstruction/PanTau/PanTauAlgs/Root/Tool_FeatureExtractor.cxx

Adding @goetz ,@xiaozhon ,@adbailey as watchers

added 22.0 Reconstruction Tau review-pending-level-1 labels

added 1 commit

• 3a3ceaad - leftover renaming

Compare with previous version

This merge request affects 1 package:

• Reconstruction/PanTau/PanTauAlgs

This merge request affects 7 files:

• Reconstruction/PanTau/PanTauAlgs/PanTauAlgs/PanTauSeed.h
• Reconstruction/PanTau/PanTauAlgs/PanTauAlgs/TauConstituent.h
• Reconstruction/PanTau/PanTauAlgs/PanTauAlgs/Tool_DetailsArranger.h
• Reconstruction/PanTau/PanTauAlgs/PanTauAlgs/Tool_FeatureExtractor.h
• Reconstruction/PanTau/PanTauAlgs/Root/TauConstituent.cxx
• Reconstruction/PanTau/PanTauAlgs/Root/Tool_DetailsArranger.cxx
• Reconstruction/PanTau/PanTauAlgs/Root/Tool_FeatureExtractor.cxx

Adding @goetz ,@xiaozhon ,@adbailey as watchers

added 1 commit

• a27febb2 - const methods

Compare with previous version

This merge request affects 1 package:

• Reconstruction/PanTau/PanTauAlgs

This merge request affects 10 files:

• Reconstruction/PanTau/PanTauAlgs/PanTauAlgs/ITool_InformationStore.h
• Reconstruction/PanTau/PanTauAlgs/PanTauAlgs/PanTauSeed.h
• Reconstruction/PanTau/PanTauAlgs/PanTauAlgs/TauConstituent.h
• Reconstruction/PanTau/PanTauAlgs/PanTauAlgs/Tool_DetailsArranger.h
• Reconstruction/PanTau/PanTauAlgs/PanTauAlgs/Tool_FeatureExtractor.h
• Reconstruction/PanTau/PanTauAlgs/PanTauAlgs/Tool_InformationStore.h
• Reconstruction/PanTau/PanTauAlgs/Root/TauConstituent.cxx
• Reconstruction/PanTau/PanTauAlgs/Root/Tool_DetailsArranger.cxx
• Reconstruction/PanTau/PanTauAlgs/Root/Tool_FeatureExtractor.cxx
• Reconstruction/PanTau/PanTauAlgs/Root/Tool_InformationStore.cxx

Adding @goetz ,@xiaozhon ,@adbailey as watchers

CI Result SUCCESS (hash 0966f768)

	Athena	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 53117]

CI Result SUCCESS (hash 3a3ceaad)

	Athena	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 53119]

CI Result SUCCESS (hash a27febb2)

	Athena	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 53137]

added review-approved-tier0 label

Just one small question, otherwise approving. L1

removed review-pending-level-1 label

added review-approved review-user-action-required labels

resolved all threads

removed review-user-action-required label

added review-approved-point1 label

mentioned in commit 97bedd12

merged