tauRec: don't call tool finalize from within algorithm, and use smart pointers...

tauRec: don't call tool finalize from within algorithm, and use smart pointers in PanTau to avoid delete in finalize

Hello,

With this MR, we no longer manually call the finalize method of tau tools from within tau algorithms, we let Athena do it (discussed in !50531 (comment 5338603), possibly relevant for ATLASRECTS-7047 too?). Besides, now, we no longer do anything in tool finalize. This is achieved by replacing raw pointers with smart pointers in PanTau. We no longer use the MVAUtils BDT method that relies on a vector of float pointers, we use a vector of floats (possibly lighter for memory). We no longer use variable caching to evaluate BDTs in PanTau, making one more step towards re-entrancy. PanTau::Tool_ModeDiscriminator::getResponse can't be turned to const yet, but we're getting close...

The MR does not change the reconstruction output.

Cheers, Bertrand

This merge request affects 3 packages:

• Reconstruction/PanTau/PanTauAlgs
• Reconstruction/tauRec
• Reconstruction/tauRecTools

Affected files list will not be printed in this case

Adding @goetz ,@martindl ,@adbailey ,@xiaozhon as watchers

added 22.0 Reconstruction Tau review-pending-level-1 labels

CI Result SUCCESS (hash cd89ec98)

	Athena	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 53131]

Just one nitpicky comment. Otherwise approving. L1

removed review-pending-level-1 label

added review-user-action-required label

added 1 commit

• d099c8bf - replace c-cast with static_cast

Compare with previous version

resolved all threads

This merge request affects 3 packages:

• Reconstruction/PanTau/PanTauAlgs
• Reconstruction/tauRec
• Reconstruction/tauRecTools

Affected files list will not be printed in this case

Adding @goetz ,@martindl ,@adbailey ,@xiaozhon as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash d099c8bf)

	Athena	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 53156]

Thanks a lot for changing! Approving now. L1

removed review-pending-level-1 label

added review-approved label

added review-approved-point1 label

added review-approved-tier0 label

mentioned in commit dcb3d58d

merged