Skip to content

tauRec: don't call tool finalize from within algorithm, and use smart pointers...

Bertrand Martin Dit Latour requested to merge martindl/athena:R22_TauRecFinalize into 22.0

tauRec: don't call tool finalize from within algorithm, and use smart pointers in PanTau to avoid delete in finalize

Hello,

With this MR, we no longer manually call the finalize method of tau tools from within tau algorithms, we let Athena do it (discussed in !50531 (comment 5338603), possibly relevant for ATLASRECTS-7047 too?). Besides, now, we no longer do anything in tool finalize. This is achieved by replacing raw pointers with smart pointers in PanTau. We no longer use the MVAUtils BDT method that relies on a vector of float pointers, we use a vector of floats (possibly lighter for memory). We no longer use variable caching to evaluate BDTs in PanTau, making one more step towards re-entrancy. PanTau::Tool_ModeDiscriminator::getResponse can't be turned to const yet, but we're getting close...

The MR does not change the reconstruction output.

Cheers, Bertrand

Merge request reports