Skip to content
Snippets Groups Projects

LAr calib patching extension

Merged Pavol Strizenec requested to merge pavol/athena:calib_patch_from_reference into master
All threads resolved!

This MR is to extend the possibility to patch channels pulsed by some calibration board (which could be faulty or missing) by the conditions from the reference (coming from DB), instead of averaging over another channels in the same run.

This code is not used in standard reco, only in the calibration runs processing.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Carlo Varni
  • Carlo Varni
  • added 1 commit

    • e553c911 - adding event context for ReadCondHandles

    Compare with previous version

  • Pavol Strizenec resolved all threads

    resolved all threads

  • This merge request affects 3 packages:

    • LArCalorimeter/LArCalibDataQuality
    • LArCalorimeter/LArCalibUtils
    • LArCalorimeter/LArExample/LArCalibProcessing

    Affected files list will not be printed in this case

    Adding @pavol as watcher

  • :pencil: There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

  • added 1 commit

    Compare with previous version

  • This merge request affects 3 packages:

    • LArCalorimeter/LArCalibDataQuality
    • LArCalorimeter/LArCalibUtils
    • LArCalorimeter/LArExample/LArCalibProcessing

    Affected files list will not be printed in this case

    Adding @pavol as watcher

  • Pavol Strizenec resolved all threads

    resolved all threads

  • added 1 commit

    • 70609a3c - even context in LArCalibPatchingAlg

    Compare with previous version

  • This merge request affects 3 packages:

    • LArCalorimeter/LArCalibDataQuality
    • LArCalorimeter/LArCalibUtils
    • LArCalorimeter/LArExample/LArCalibProcessing

    Affected files list will not be printed in this case

    Adding @pavol as watcher

  • :white_check_mark: CI Result SUCCESS (hash e553c911)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 53379]

  • :white_check_mark: CI Result SUCCESS (hash 70609a3c)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 53427]

  • :white_check_mark: CI Result SUCCESS (hash 83269b62)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 53426]

  • Kira Abeling
  • Only one minor clarification in addition to the previous L1 comments. Looks good otherwise.

    Kira (L1)

  • Pavol Strizenec resolved all threads

    resolved all threads

  • comments have been addressed. Approving -- L1

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit f2b62787

  • Atlas Nightlybuild picked the changes into the branch cherry-pick-f2b62787218-22.0 with commit b1470e89

    picked the changes into the branch cherry-pick-f2b62787218-22.0 with commit b1470e89

  • mentioned in commit b1470e89

  • Atlas Nightlybuild mentioned in merge request !53959 (merged)

    mentioned in merge request !53959 (merged)

  • Julien Maurer mentioned in commit cdcf574d

    mentioned in commit cdcf574d

  • mentioned in commit 56cc7066

  • Please register or sign in to reply
    Loading