Skip to content
Snippets Groups Projects

Allow use of any offline collection as the reference

Merged Mark Sutton requested to merge sutt/athena:t0lrt into 22.0
All threads resolved!

Allows the collection name of the of the offline reference to be specified in the configuration of the analysis for the tier - analysis

Merge request reports

Pipeline #4048013 passed

Pipeline passed for 01600f0c on sutt:t0lrt

Approval is optional

Merged by Benjamin Philip KerridgeBenjamin Philip Kerridge 2 years ago (Jun 3, 2022 12:20pm UTC)

Merge details

  • Changes merged into 22.0 with f8b4bd83 (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Kira Abeling
  • Kira Abeling
  • Kira Abeling
  • Kira Abeling
  • Kira Abeling
  • Kira Abeling
  • Changes look generally fine but I found a few mismatches between the message level check and what is actually written. Could you please clarify what's the motivation for this?

    Kira (L1)

  • Setting review-user-action-required while open threads are being resolved -- L1

  • Author Developer

    Hi, why has the "user action required" been added ? I have already responded to the comments and am just waiting to hear from the reviewer as I am fine with the changes as they are, so I could resolve the threads myself, but thought it was polite to give the revciewer a chance to respond.

    The only item I have not responded to is the request to change the indentation if I am making other changes, although it looks ok to me. Given that pretty much all our other monitoring changes have been held up for many days for some reason, I would rather we just have this merged as is rather than accumulate even more delays.

    Cheers Mark

    Edited by Mark Sutton
  • Hi @sutt if you have already addressed the open threads I'd say you can resolve them. The review-user-action-required was indeed to remove this MR from the list of MR to review while open threads were still present. I'm adding back review-pending-level-1 since from what you say the threads are technically being addressed.

  • Author Developer

    OK thanks Carlo.

    Cheers Mark

  • Hi @sutt,

    while I understand the logic behind the warning messages, I think it is confusing and not desired to print out warning messages only at debug level, for instance. Warning messages should print out at warning level and debug messages at debug level. However, as it seems this was already done in the past and there is some urgency in this MR, I am resolving the threads and approving. Maybe something to change in the future :)

    Cheers,

    Joshua (L1)

  • Joshua Falco Beirer resolved all threads

    resolved all threads

  • mentioned in commit f8b4bd83

  • Please register or sign in to reply
    Loading