Allow use of any offline collection as the reference
Allows the collection name of the of the offline reference to be specified in the configuration of the analysis for the tier - analysis
Merge request reports
Activity
This merge request affects 1 package:
- Trigger/TrigAnalysis/TrigInDetAnalysisExample
This merge request affects 6 files:
- Trigger/TrigAnalysis/TrigInDetAnalysisExample/TrigInDetAnalysisExample/T_AnalysisConfigR3_Tier0.h
- Trigger/TrigAnalysis/TrigInDetAnalysisExample/TrigInDetAnalysisExample/T_AnalysisConfig_Tier0.h
- Trigger/TrigAnalysis/TrigInDetAnalysisExample/src/AnalysisConfigMT_Ntuple.cxx
- Trigger/TrigAnalysis/TrigInDetAnalysisExample/src/AnalysisConfig_Ntuple.cxx
- Trigger/TrigAnalysis/TrigInDetAnalysisExample/src/TrigR3Mon.cxx
- Trigger/TrigAnalysis/TrigInDetAnalysisExample/src/TrigR3Mon.h
added 22.0 Trigger review-pending-level-1 labels
added 1 commit
- 8bdfe87d - allow both truth and offline for the ntuple creation
This merge request affects 1 package:
- Trigger/TrigAnalysis/TrigInDetAnalysisExample
This merge request affects 6 files:
- Trigger/TrigAnalysis/TrigInDetAnalysisExample/TrigInDetAnalysisExample/T_AnalysisConfigR3_Tier0.h
- Trigger/TrigAnalysis/TrigInDetAnalysisExample/TrigInDetAnalysisExample/T_AnalysisConfig_Tier0.h
- Trigger/TrigAnalysis/TrigInDetAnalysisExample/src/AnalysisConfigMT_Ntuple.cxx
- Trigger/TrigAnalysis/TrigInDetAnalysisExample/src/AnalysisConfig_Ntuple.cxx
- Trigger/TrigAnalysis/TrigInDetAnalysisExample/src/TrigR3Mon.cxx
- Trigger/TrigAnalysis/TrigInDetAnalysisExample/src/TrigR3Mon.h
This merge request affects 1 package:
- Trigger/TrigAnalysis/TrigInDetAnalysisExample
This merge request affects 6 files:
- Trigger/TrigAnalysis/TrigInDetAnalysisExample/TrigInDetAnalysisExample/T_AnalysisConfigR3_Tier0.h
- Trigger/TrigAnalysis/TrigInDetAnalysisExample/TrigInDetAnalysisExample/T_AnalysisConfig_Tier0.h
- Trigger/TrigAnalysis/TrigInDetAnalysisExample/src/AnalysisConfigMT_Ntuple.cxx
- Trigger/TrigAnalysis/TrigInDetAnalysisExample/src/AnalysisConfig_Ntuple.cxx
- Trigger/TrigAnalysis/TrigInDetAnalysisExample/src/TrigR3Mon.cxx
- Trigger/TrigAnalysis/TrigInDetAnalysisExample/src/TrigR3Mon.h
CI Result SUCCESS (hash cf7f4d75) Athena DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 53446] CI Result SUCCESS (hash 8bdfe87d) Athena DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 53447] CI Result SUCCESS (hash 01600f0c) Athena DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 53449] added review-approved-tier0 label
- Resolved by Joshua Falco Beirer
- Resolved by Joshua Falco Beirer
- Resolved by Joshua Falco Beirer
- Resolved by Joshua Falco Beirer
- Resolved by Joshua Falco Beirer
- Resolved by Joshua Falco Beirer
- Resolved by Mark Sutton
added review-user-action-required label and removed review-pending-level-1 label
removed review-user-action-required label
added review-pending-level-1 label
Setting review-user-action-required while open threads are being resolved -- L1
added review-user-action-required label and removed review-pending-level-1 label
Hi, why has the "user action required" been added ? I have already responded to the comments and am just waiting to hear from the reviewer as I am fine with the changes as they are, so I could resolve the threads myself, but thought it was polite to give the revciewer a chance to respond.
The only item I have not responded to is the request to change the indentation if I am making other changes, although it looks ok to me. Given that pretty much all our other monitoring changes have been held up for many days for some reason, I would rather we just have this merged as is rather than accumulate even more delays.
Cheers Mark
Edited by Mark SuttonHi @sutt if you have already addressed the open threads I'd say you can resolve them. The review-user-action-required was indeed to remove this MR from the list of MR to review while open threads were still present. I'm adding back review-pending-level-1 since from what you say the threads are technically being addressed.
added review-pending-level-1 label and removed review-user-action-required label
Hi @sutt,
while I understand the logic behind the warning messages, I think it is confusing and not desired to print out warning messages only at debug level, for instance. Warning messages should print out at warning level and debug messages at debug level. However, as it seems this was already done in the past and there is some urgency in this MR, I am resolving the threads and approving. Maybe something to change in the future :)
Cheers,
Joshua (L1)
removed review-pending-level-1 label
added review-approved label
added review-approved-point1 label
mentioned in commit f8b4bd83