ICaloSurfaceBuilder rm seemingly unused methods

ICaloSurfaceBuilder rm seemingly unused methods

added alsoTargeting:22.0 label

This merge request affects 1 package:

• Calorimeter/CaloTrackingGeometry

This merge request affects 3 files:

• Calorimeter/CaloTrackingGeometry/CaloTrackingGeometry/CaloSurfaceBuilder.h
• Calorimeter/CaloTrackingGeometry/CaloTrackingGeometry/ICaloSurfaceBuilder.h
• Calorimeter/CaloTrackingGeometry/src/CaloSurfaceBuilder.cxx

Adding @pavol ,@amorley as watchers

added Calorimeter JetEtmiss master review-pending-level-1 labels

@tsulaia @wlampl , perhaps not important at this stage but there are couple of extra methods that are used only in the test [https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/LArCalorimeter/LArExample/TestLArDetDescr/src/TestLArMaterial.cxx]

that could also be removed if the test is obsolete .

CI Result SUCCESS (hash 19082d57)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 53509]

resolved all threads

Changes and CI look fine from an L1 point of view. Forwarding to L2 to look at code removal. L1

removed review-pending-level-1 label

added review-pending-level-2 label

added review-approved label and removed review-pending-level-2 label

merged

mentioned in commit 6476b64b

added sweep:done label

picked the changes into the branch cherry-pick-6476b64b4c2-22.0 with commit 52bafd05

mentioned in commit 52bafd05

Sweep summary
successful:

• 22.0

(see https://aiatlas154.cern.ch/jenkins/job/auto_git_sweeps/2713/console for details)

mentioned in merge request !54001 (merged)

mentioned in commit 1d28ec13

mentioned in commit 5d30cbbd