remove the cmake option and compile cuda part as default

remove the USE_GPU option and definition in cmake, compile the cuda part in FastCaloSim-GPU if cuda is found. There will be some warning that it can not find some functions, i.e. LoadHistFuncsGpu, when loading the parameterization file, it should be fixed when we produce a new parameterization file with the cuda code included.

Ping @akraszna , @jchapman , @tlari , @mfauccig and @cyoung .

added Simulation master labels

This merge request affects 2 packages:

• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimServices

Affected files list will not be printed in this case

Adding @jchapman ,@pjacka ,@mfauccig ,@xiaozhon ,@ahasib ,@tadej ,@schaarsc as watchers

added JetEtmiss review-pending-level-1 labels

CI Result FAILURE (hash 2fbdfb17)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 53655]

So... what happens in this setup when trying to use FCS on a machine with no NVIDIA GPU? Can the non-GPU version of FCS still run? Do we have some jobO that would decide between the CPU and GPU versions of FCS?

I'd really just like to fully understand how these jobs will actually run...

P.S. I have no idea if the test failure is actually because of this MR. I'm not convinced that it is, but since it's a simulation failure, it's not impossible that it would be.

Moving to review-user-action-required for now - until discussions are resolved.

Jakub (L1 shifter)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 67425759 - revise the place of USE_GPU definition and make USE_GPU to false as default

Compare with previous version

This merge request affects 2 packages:

• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimServices

Affected files list will not be printed in this case

Adding @jchapman ,@pjacka ,@mfauccig ,@xiaozhon ,@ahasib ,@tadej ,@schaarsc as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash 67425759)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 53780]

Hi @keli , the CI failure looks real. Could you please have a look? Thanks.

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 4da5868d - fix the error in CI tests

Compare with previous version

This merge request affects 2 packages:

• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimServices

Affected files list will not be printed in this case

Adding @jchapman ,@pjacka ,@mfauccig ,@xiaozhon ,@ahasib ,@tadej ,@schaarsc as watchers

added review-pending-level-1 label and removed review-user-action-required label

added 1 commit

• 00d466a8 - touch all the classs related with cuda to force it to rebuild the dict

Compare with previous version

This merge request affects 2 packages:

• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimServices

Affected files list will not be printed in this case

Adding @jchapman ,@pjacka ,@mfauccig ,@xiaozhon ,@ahasib ,@tadej ,@schaarsc as watchers

CI Result SUCCESS (hash 4da5868d)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 53791]