fixing bug with gap/crack cell dimensions for RUN2/RUN3 - reading actual values from DB (ATLASRECTS-7085)

All values needed to calculate cell and sampling dimensions are taken from GeoModel DB now instead of hard-coded values which are valid only for RUN1 geometry

WARNING: big files (>100K) are found in the changeset

144K in file TileCalorimeter/TileGeoModel/src/TileGeoSectionBuilder.cxx

This merge request affects 2 packages:

• TileCalorimeter/TileDetDescr
• TileCalorimeter/TileGeoModel

Affected files list will not be printed in this case

Adding @pavol ,@harkusha ,@solodkov as watchers

added JetEtmiss Tile master review-pending-level-1 labels

added Run2-FullSim-output-changed Run3-FullSim-output-changed labels

CI Result FAILURE (hash 38341624)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 54057]

Hi

• I see TileHitVector_p1_TileHitVec changing this is expected ping @jchapman

• I also see changed output in Tau chains but not sure if this is caused by this (maybe) or something else.

• I guess to see full-diff for reco one should hafe requested to 22.0 directly ?

added RC Attention Required bugfix labels

Could you please investigate the failing tests?

Thanks, Kira (L1)

added review-user-action-required label and removed review-pending-level-1 label

resolved all threads

Hi @solodkov are you preparing the update of the reference files for the CI tests ?

Also, I think we agreed that this should go to 22.0 as well - not sure whether it's better to add an "also targeting:22.0" label or open a new MR entirely

cheers, Tommaso

Hi @solodkov - is there any news here? We have just discussed this in the OAB meeting and we'd really like to try to get this into both master and 22.0 ASAP.

mentioned in merge request !54592 (closed)

mentioned in merge request !54593 (merged)

Hello Could you please tell me which CI tests are failing right now ?

Jenkins please retry a build

Actually we will see in the other MR , but let me re-run here to get fresh results

WARNING: big files (>100K) are found in the changeset

144K in file TileCalorimeter/TileGeoModel/src/TileGeoSectionBuilder.cxx

This merge request affects 2 packages:

• TileCalorimeter/TileDetDescr
• TileCalorimeter/TileGeoModel

Affected files list will not be printed in this case

Adding @pavol ,@harkusha ,@solodkov as watchers

added review-pending-level-1 label and removed review-user-action-required label

added Run2-DataReco-output-changed Run3-DataReco-output-changed labels

CI Result FAILURE (hash 38341624)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 54851]

added 879 commits

• 38341624...2b139341 - 876 commits from branch atlas:master
• 3924bbfc - fixing bug with gap/crack cell dimensions for RUN2/RUN3 - reading actual values from DB
• efda404e - updating reference for CITest_TriggerMC
• 167bcbbe - Merge branch 'tilecal-for-22.0' of https://gitlab.cern.ch:8443/solodkov/athena...

Compare with previous version

WARNING: big files (>100K) are found in the changeset

144K in file TileCalorimeter/TileGeoModel/src/TileGeoSectionBuilder.cxx

296K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

This merge request affects 3 packages:

• TileCalorimeter/TileDetDescr
• TileCalorimeter/TileGeoModel
• Trigger/TrigValidation/TrigAnalysisTest

Affected files list will not be printed in this case

Adding @vmartin ,@pavol ,@okumura ,@harkusha ,@solodkov as watchers

added Trigger changes-trigger-counts labels

CI Result FAILURE (hash 167bcbbe)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 54904]

Hi @solodkov the CI is complaining with trigger count changes and leaves differences with respect to reference. Can you address these?

-- L1

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• d8564ae1 - updating trigger reference file - second attempt

Compare with previous version

WARNING: big files (>100K) are found in the changeset

144K in file TileCalorimeter/TileGeoModel/src/TileGeoSectionBuilder.cxx

296K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

This merge request affects 3 packages:

• TileCalorimeter/TileDetDescr
• TileCalorimeter/TileGeoModel
• Trigger/TrigValidation/TrigAnalysisTest

Affected files list will not be printed in this case

Adding @vmartin ,@pavol ,@okumura ,@harkusha ,@solodkov as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash d8564ae1)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 54962]

added review-user-action-required label and removed review-pending-level-1 label

There are still a bunch of failing tests. Are all of these expected/desired?

Kira (L1)

I am waiting for new references to be installed in CVMFS, after that I'll update the tests

mentioned in merge request !54790 (merged)

mentioned in merge request !54812 (merged)

mentioned in merge request !54814 (merged)

Hi @solodkov, can you point us to the files?

added 716 commits

• d8564ae1...77515b3a - 715 commits from branch atlas:master
• 9daf0746 - fixing bug with gap/crack cell dimensions for RUN2/RUN3 - reading actual values from DB

Compare with previous version

Hi @solodkov, I took the liberty to rebase. Will update references in the next step.

WARNING: big files (>100K) are found in the changeset

144K in file TileCalorimeter/TileGeoModel/src/TileGeoSectionBuilder.cxx

This merge request affects 2 packages:

• TileCalorimeter/TileDetDescr
• TileCalorimeter/TileGeoModel

Affected files list will not be printed in this case

Adding @pavol ,@harkusha ,@solodkov as watchers

added review-pending-level-1 label and removed review-user-action-required label

Thanks, @tadej New POOL files are in ~solodkov/work/public/ci_test/master/ I prepared new POOL files for 4 tests, because I saw that they were failing But right now I am rerunning all tests, just to make sure that noting changed since last week I'll put new POOL files to the same place in an hour

No need to! John already checked and the output is the same as in 22.0 (as expected). I already copied the files, we're just waiting for the sync now.

CI Result FAILURE (hash 9daf0746)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 55548]