KLGaussianReduction organise and comment the code better

KLGaussianReduction organise and comment the code better

In general we have made some particular choices on this code, as can be a significant cost when running with high numbers of state/material effects components (ATLAS uses GSF 12/6)

• Re-organise the code in groups and add comments on what we try to do and its complexity
• Add also extra references that include alternative algorithms . This might be interesting if we want to revisit things in the future.
• In terms of almost real code changes other than some better names, merge the 2 methods doing the recalculate / resetsteps in one update

added alsoTargeting:22.0 label

This merge request affects 1 package:

• Tracking/TrkFitter/TrkGaussianSumFilterUtils

This merge request affects 2 files:

• Tracking/TrkFitter/TrkGaussianSumFilterUtils/TrkGaussianSumFilterUtils/KLGaussianMixtureReduction.h
• Tracking/TrkFitter/TrkGaussianSumFilterUtils/src/KLGaussianMixtureReduction.cxx

Adding @amorley as watcher

added Egamma Tracking master review-pending-level-1 labels

changed the description

CI Result SUCCESS (hash c5a5c940)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 54081]

added 1 commit

• 38cc26b0 - fix typos add comment on data structures

Compare with previous version

Jenkins please retry a build

This merge request affects 1 package:

• Tracking/TrkFitter/TrkGaussianSumFilterUtils

This merge request affects 2 files:

• Tracking/TrkFitter/TrkGaussianSumFilterUtils/TrkGaussianSumFilterUtils/KLGaussianMixtureReduction.h
• Tracking/TrkFitter/TrkGaussianSumFilterUtils/src/KLGaussianMixtureReduction.cxx

Adding @amorley as watcher

CI Result SUCCESS (hash 38cc26b0)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 54089]

added review-pending-level-2 label and removed review-pending-level-1 label

Changes and CI look fine from L1 point of view. Passing on to L2 to cross check that I didn't miss anything in the regrouping/organisation since it's quite confusing to review.

Kira (L1)

Changes look good, approving.

Sergio (L2)

added review-approved label and removed review-pending-level-2 label

resolved all threads

merged

mentioned in commit 23691d53

added sweep:done label

picked the changes into the branch cherry-pick-23691d53b25-22.0 with commit 72853630

mentioned in commit 72853630

mentioned in merge request !54233 (merged)

Sweep summary
successful:

• 22.0

(see https://aiatlas154.cern.ch/jenkins/job/auto_git_sweeps/2741/console for details)

mentioned in commit 5bee8a08

mentioned in commit d6ee460a