Skip to content
Snippets Groups Projects

Move tracking expected hit info computation from TrackSummaryHelper to TrackParticleCreator

Merged Move tracking expected hit info computation from TrackSummaryHelper to TrackParticleCreator
tstreble/athena:ExpHitTrkPart into master
Merged Thomas Strebler requested to merge tstreble/athena:ExpHitTrkPart into master

Following previous discussions with @christos, this MR aims at removing the computation of the expected hit information in the innermost pixel layers from the TrackSummaryHelper and the associated variables from the Trk::TrackSummary object into the TrackParticleCreator tool and the xAOD::TrackParticle variables, similarly to what was done for the TRT and pixel PID variables in !53027 (merged)

q445 AOD outputs unchanged, both for RecExCommon and CA configs. Run 4 q447 AOD outputs updated, following enabling of expected hit information for GSF TrackParticles. The current config had this protected behind if flags.Detector.EnablePixel: here TrkTrackSummaryToolConfig.py#L203, as no ITk bypass had been implemented yet for InDetTestPixelLayerToolInnerCfg

For master only as the InDet monitoring has been left unchanged in 22.0 to avoid disturbance in data-taking monitoring.

FYI @goetz

Edited by Thomas Strebler

Merge request reports

Pipeline #4225262 passed

Stage: external

Pipeline passed for e1767046 on tstreble:ExpHitTrkPart

Approval is optional

Merged by Tadej NovakTadej Novak 2 years ago (Jul 15, 2022 7:59pm UTC)

Merge details

  • Changes merged into master with 2bddd608 (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thomas Strebler added InnerDetector Tracking labels

    added InnerDetector Tracking labels

  • Christos Anastopoulos
    Christos Anastopoulos @christos ·
    Developer

    yes something like this is what I have in mind. I think this is how you added the extra "expected ones" for Run-4 .

    Let me mention ATLASRECTS-2807

    At the end we are going to have TrackParticleCreatorConfig.py I guess maybe in another MR ...

    Edited by Christos Anastopoulos
  • Thomas Strebler added 591 commits

    added 591 commits

    • 37325d63...461dcb3e - 584 commits from branch atlas:master
    • 9ab53e6d - Add computation of expected hit info in TrackParticleCreatorTool
    • e3fedb2e - Remove computation of expected hit info from InDetTrackSummaryHelperTool 1/2
    • 535f5fd6 - Removed expected hit functions from TrackSummaryHelper
    • 19f644c1 - Used xAOD::expectInnermostPixelLayerHit from TrackParticle for decision
    • 51937048 - Removed TestPixelLayer tool from TrackSummaryHelper config
    • 750cfbeb - Updated config of TrackParticleCreatorTool for expected hit info computation
    • 5e33dd51 - Minor fixes

    Compare with previous version

    Toggle commit list
  • Thomas Strebler added 1 commit

    added 1 commit

    • 726f58ee - Fixes in RecExCommon configs

    Compare with previous version

  • Thomas Strebler added 1 commit

    added 1 commit

    • 4be25e83 - Added ITk bypass for TestPixelLayerTool config for EMBremCollectionBuilder

    Compare with previous version

  • Thomas Strebler added 80 commits

    added 80 commits

    • 4be25e83...4afcdfa5 - 68 commits from branch atlas:master
    • 4de93509 - Add computation of expected hit info in TrackParticleCreatorTool
    • 3e02c1d3 - Remove computation of expected hit info from InDetTrackSummaryHelperTool 1/2
    • 793d9c00 - Removed expected hit functions from TrackSummaryHelper
    • 2bef4fbe - Used xAOD::expectInnermostPixelLayerHit from TrackParticle for decision
    • 5748fd5b - Removed TestPixelLayer tool from TrackSummaryHelper config
    • 814b7e5c - Updated config of TrackParticleCreatorTool for expected hit info computation
    • 85577a88 - Minor fixes
    • 8077d945 - Fixes in RecExCommon configs
    • feeb06cc - Added ITk bypass for TestPixelLayerTool config for EMBremCollectionBuilder
    • d4454c1a - Updates for LRT + muon
    • fae4f071 - Updates for combined muons
    • ba5af032 - Minor fixes

    Compare with previous version

    Toggle commit list
    • G
      Goetz Gaycken @goetz ·
      Developer
      Resolved by Thomas Strebler

      There are several monitoring tools which access this information from the TrackSummary of Trk::Track. There is also the METEgammaAssociator base of the METElectronAssociator, METPhotonAssociator, which are in use. So, these tools would need to be modified to get this information from the track particle rather than the track.

  • Thomas Strebler added 1 commit

    added 1 commit

    • 29d7cadf - Add computation of expected hit info in TrackParticleCreatorTool

    Compare with previous version

  • Thomas Strebler added 63 commits

    added 63 commits

    • 29d7cadf...70199d8c - 55 commits from branch atlas:master
    • ab1f7abb - CA config for TrkParticleCreator package 1/2
    • c847a794 - CA config for TrkParticleCreator package 2/2
    • 8c89758a - Fixed CI tests
    • 14f55b12 - Assign sTGC hit ID to the wire readout (ATLASSIM-3539)
    • fd5deb96 - Add extra TgcDigitizationTool property to test_MC16a_Digi_tf_configuration (ATLASSIM-5904)
    • df37fdd0 - Add computation of expected hit info in TrackParticleCreatorTool
    • e00484e2 - Removed addDetailedHitInformation for r22 rebase
    • f56d662c - Disable ExpHit computation for LRT EGamma

    Compare with previous version

    Toggle commit list
  • Thomas Strebler changed target branch from master to 22.0

    changed target branch from master to 22.0

  • Thomas Strebler added 73 commits

    added 73 commits

    • f56d662c...2825ce1e - 67 commits from branch atlas:22.0
    • 251d69b7 - CA config for TrkParticleCreator package 1/2
    • b1b4003c - CA config for TrkParticleCreator package 2/2
    • ea491ce4 - Add computation of expected hit info in TrackParticleCreatorTool
    • cf911e48 - Removed addDetailedHitInformation for r22 rebase
    • cac408fe - Disable ExpHit computation for LRT EGamma
    • 03a9b151 - Updates for LRT

    Compare with previous version

    Toggle commit list
  • Thomas Strebler added 128 commits

    added 128 commits

    • 03a9b151...a743dc9f - 121 commits from branch atlas:22.0
    • 43bb92b9 - CA config for TrkParticleCreator package 1/2
    • 7167176c - CA config for TrkParticleCreator package 2/2
    • 66a33688 - Add computation of expected hit info in TrackParticleCreatorTool
    • 4575b981 - Removed addDetailedHitInformation for r22 rebase
    • 8893e3e5 - Disable ExpHit computation for LRT EGamma
    • 63f74b71 - Updates for LRT
    • 56bd8110 - Update addExpectedHitInformation for muons vs other particles

    Compare with previous version

    Toggle commit list
  • Thomas Strebler added 6 commits

    added 6 commits

    • 3729c0cb - Update InDetGlobalTrackMonTool to use TrackParticle + general cleaning
    • 9af50d0f - Add computation of expected hit info in TrackParticleCreatorTool
    • f4edc9e4 - Removed addDetailedHitInformation for r22 rebase
    • 291aa743 - Disable ExpHit computation for LRT EGamma
    • c9dc68d4 - Updates for LRT
    • c2f6d6b6 - Update addExpectedHitInformation for muons vs other particles

    Compare with previous version

    Toggle commit list
  • Thomas Strebler changed target branch from 22.0 to master

    changed target branch from 22.0 to master

  • Thomas Strebler added 1081 commits

    added 1081 commits

    • c2f6d6b6...b61a8fe0 - 1076 commits from branch atlas:master
    • cd24d7c9 - Update InDetGlobalTrackMonTool to use TrackParticle + general cleaning
    • 5b7c4ad5 - Add computation of expected hit info in TrackParticleCreatorTool
    • e813168c - Disable ExpHit computation for LRT EGamma
    • db96169f - Updates for LRT
    • 8a337801 - Update addExpectedHitInformation for muons vs other particles

    Compare with previous version

    Toggle commit list
  • Thomas Strebler mentioned in merge request !54773 (merged)

    mentioned in merge request !54773 (merged)

  • Thomas Strebler mentioned in merge request !54825 (merged)

    mentioned in merge request !54825 (merged)

  • Thomas Strebler mentioned in merge request !54829 (merged)

    mentioned in merge request !54829 (merged)

  • Thomas Strebler resolved all threads

    resolved all threads

  • Thomas Strebler added 164 commits

    added 164 commits

    • 8a337801...4a715fbc - 160 commits from branch atlas:master
    • 66f8085b - Add computation of expected hit info in TrackParticleCreatorTool
    • 21f3a3d6 - Disable ExpHit computation for LRT EGamma
    • 856250c5 - Updates for LRT
    • 5662e2b1 - Update addExpectedHitInformation for muons vs other particles

    Compare with previous version

    Toggle commit list
  • Thomas Strebler added 1 commit

    added 1 commit

    • 3a7d537e - Removed repeated addDetailedHitInformation

    Compare with previous version

  • Thomas Strebler added full-build label

    added full-build label

  • Thomas Strebler added 1 commit

    added 1 commit

    • cc1ac74c - Restore Detector.EnablePixel protection for GSF TestPixelLayerTool

    Compare with previous version

  • Thomas Strebler changed the description

    changed the description

  • Thomas Strebler marked this merge request as ready

    marked this merge request as ready

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 104K in file InnerDetector/InDetExample/InDetRecExample/python/TrackingCommon.py

  • Thomas Strebler changed the description

    changed the description

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :pushpin: build area is cleaned as MR is labeled as full-build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 18 packages:

    • InnerDetector/InDetConfig
    • InnerDetector/InDetEventCnv/InDetPrepRawDataToxAOD
    • InnerDetector/InDetExample/InDetAlignExample
    • InnerDetector/InDetExample/InDetRecExample
    • InnerDetector/InDetExample/InDetTrigRecExample
    • InnerDetector/InDetRecTools/InDetRecToolInterfaces
    • InnerDetector/InDetRecTools/InDetTestPixelLayer
    • InnerDetector/InDetRecTools/InDetTrackSelectorTool
    • InnerDetector/InDetRecTools/InDetTrackSummaryHelperTool
    • MuonSpectrometer/MuonReconstruction/MuonRecTools/MuonTrackSummaryHelperTool
    • Reconstruction/MuonIdentification/MuonCombinedBaseTools
    • Reconstruction/MuonIdentification/MuonCombinedRecExample
    • Tracking/TrkConfig
    • Tracking/TrkEvent/TrkTrackSummary
    • Tracking/TrkTools/TrkParticleCreator
    • Tracking/TrkTools/TrkToolInterfaces
    • Tracking/TrkTools/TrkTrackSummaryTool
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @goetz ,@sutt ,@amorley ,@wleight ,@stavrop ,@battagl ,@sroe ,@nagano ,@rosati ,@jojungge ,@apsallid ,@pscholer ,@stsuno ,@lshan ,@bernius ,@gavrilen as watchers

  • ATLAS Robot added MuonSpectrometer Reconstruction Trigger TriggerMenu master review-pending-level-1 labels

    added MuonSpectrometer Reconstruction Trigger TriggerMenu master review-pending-level-1 labels

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :scissors: CI integration tests for projects Athena are cancelled because of compilation error(s)

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash cc1ac74c)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :o: Athena: number of compilation errors 1, warnings 2
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 55316]

    • Johannes Junggeburth
      Johannes Junggeburth @jojungge ·
      Developer
      Resolved by Thomas Strebler 
      /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigAnalysis/TrigInDetAnalysisUtils/src/TrigTrackSelector.cxx: In member function 'bool TrigTrackSelector::selectTrack(const Rec::TrackParticle*)':
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigAnalysis/TrigInDetAnalysisUtils/src/TrigTrackSelector.cxx:270:44: error: 'expectBLayerHit' is not a member of 'Trk'; did you mean 'unused_expectBLayerHit'?
  270 |       bool expectBL   = summary->get(Trk:: expectBLayerHit);
      |                                            ^~~~~~~~~~~~~~~
      |                                            unused_expectBLayerHit
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigAnalysis/TrigInDetAnalysisUtils/src/TrigTrackSelector.cxx: In member function 'bool TrigTrackSelector::selectTrack(const Trk::Track*)':
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigAnalysis/TrigInDetAnalysisUtils/src/TrigTrackSelector.cxx:998:45: error: 'expectBLayerHit' is not a member of 'Trk'; did you mean 'unused_expectBLayerHit'?
  998 |             expectBL    = summary->get(Trk::expectBLayerHit);
      |                                             ^~~~~~~~~~~~~~~
      |                                             unused_expectBLayerHit
error: Failed to execute /cvmfs/sft.cern.ch/lcg/releases/gcc/11.2.0-8a51a/x86_64-centos7/bin/g++ -DATLAS_PACKAGE_NAME="TrigInDetAnalysisUtils" -DBOOST_ALL_NO_LIB -DBOOST_ATOMIC_DYN_LINK -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_REGEX_DYN_LINK -DBOOST_SYSTEM_DYN_LINK -DBOOST_THREAD_DYN_LINK -DCLHEP_ABS_DEFINED -DCLHEP_MAX_MIN_DEFINED -DCLHEP_SQR_DEFINED -DFMT_LOCALE -DFMT_SHARED -DGAUDI_V20_COMPAT -DJSON_USE_IMPLICIT_CONVERSIONS=1 -DTrigInDetAnalysisUtils_EXPORTS -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigAnalysis/TrigInDetAnalysisUtils -I/cvmfs/sft.cern.ch/lcg/releases/Boost/1.77.0-fd33b/x86_64-centos7-gcc11-opt/include -I/cvmfs/sft.cern.ch/lcg/releases/LCG_101_ATLAS_24/fmt/7.1.3/x86_64-centos7-gcc11-opt/include -I/cvmfs/sft.cern.ch/lcg/releases/LCG_101_ATLAS_24/jsonmcpp/3.9.1/x86_64-centos7-gcc11-opt/include -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/PhysicsAnalysis/TruthParticleID/McParticleEvent -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Generators/AtlasHepMC -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthenaKernel -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/CxxUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/DataModelRoot -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthContainers -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthContainersInterfaces -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthLinks -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/SGTools -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthAllocators -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/Navigation -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/EventKernel -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkEvent/VxVertex -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/DetectorDescription/GeoPrimitives -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/EventPrimitives -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkEvent/TrkEventPrimitives -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkEvent/TrkNeutralParameters -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkDetDescr/TrkSurfaces -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/DetectorDescription/Identifier -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkEvent/TrkParametersBase -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkDetDescr/TrkDetDescrUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkDetDescr/TrkDetElementBase -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkEvent/TrkTrackLink -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkEvent/TrkParameters -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/NavFourMom -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/FourMom -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Generators/GeneratorObjects -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODTruth -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODBase -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODCore -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/RootUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/StoreGate -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Database/PersistentDataModel -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/PhysicsAnalysis/AnalysisCommon/ParticleEvent -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Reconstruction/Particle -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkEvent/TrkParticleBase -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkEvent/TrkTrack -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkEvent/TrkMaterialOnTrack -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkEvent/TrkMeasurementBase -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkEvent/TrkTrackSummary -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Reconstruction/MuonIdentification/muonEvent -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Calorimeter/CaloEvent -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Calorimeter/CaloConditions -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Calorimeter/CaloIdentifier -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Calorimeter/CaloGeoHelpers -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/DetectorDescription/AtlasDetDescr -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/DetectorDescription/IdDict -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Calorimeter/CaloCondBlobObjs -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Calorimeter/CaloDetDescr -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthenaBaseComps -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODEventInfo -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/DetectorDescription/GeoModel/GeoModelInterfaces -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/LArCalorimeter/LArGeoModel/LArReadoutGeometry -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/LArCalorimeter/LArGeoModel/LArHV -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/LArCalorimeter/LArRawConditions -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Database/AthenaPOOL/AthenaPoolUtilities -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Database/APR/CollectionBase -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Database/APR/FileCatalog -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Database/APR/POOLCore -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/LArCalorimeter/LArIdentifier -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/LArCalorimeter/LArElecCalib -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/LArCalorimeter/LArCabling -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkEvent/TrkSegment -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Reconstruction/egamma/egammaEvent -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Reconstruction/Jet/JetEvent -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Reconstruction/tauEvent -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODMuon -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODCaloEvent -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODPrimitives -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODTracking -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/MuonSpectrometer/MuonStationIndex -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODEgamma -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODPFlow -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODTau -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODJet -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODTrigger -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigEvent/TrigNavStructure -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthToolSupport/AsgTools -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthToolSupport/AsgMessaging -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigT1/TrigT1MuctpiBits -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkTools/TrkToolInterfaces -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkEvent/TrkCompetingRIOsOnTrack -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkEvent/TrkEventUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkEvent/TrkPrepRawData -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/EventContainers -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkEvent/TrkRIO_OnTrack -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigAnalysis/TrigDecisionTool -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/EventInfo -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/PhysicsAnalysis/AnalysisTrigger/AnalysisTriggerEvent -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigConfiguration/TrigConfHLTData -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigConfiguration/TrigConfL1Data -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigConfiguration/TrigConfHLTUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigEvent/TrigDecisionEvent -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigEvent/TrigSteeringEvent -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/DetectorDescription/RoiDescriptor -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/DetectorDescription/IRegionSelector -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigEvent/TrigMuonEvent -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigEvent/TrigInDetEvent -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/InnerDetector/InDetRecEvent/InDetPrepRawData -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/InnerDetector/InDetDetDescr/InDetReadoutGeometry -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/InnerDetector/InDetDetDescr/InDetIdentifier -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/DetectorDescription/ReadoutGeometryBase -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/InnerDetector/InDetConditions/InDetCondTools -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/DetectorDescription/DetDescrCond/DetDescrConditions -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/InnerDetector/InDetDetDescr/InDetGeoModelUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/DetectorDescription/GeoModel/GeoModelUtilities -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Database/RDBAccessSvc -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Database/DBLock -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/InnerDetector/InDetDetDescr/TRT_ReadoutGeometry -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/InnerDetector/InDetRawEvent/InDetRawData -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigDataAccess/TrigSerializeCnvSvc -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkEvent/TrkSpacePoint -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigEvent/TrigStorageDefinitions -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODBTagging -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODHIEvent -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODTrigBphys -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODTrigCalo -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODTrigEgamma -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODTrigL1Calo -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODTrigMinBias -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODTrigMissingET -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODTrigMuon -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODTrigRinger -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigEvent/TrigNavigation -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigEvent/TrigRoiConversion -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigSteer/TrigCompositeUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthToolSupport/AsgDataHandles -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigEvent/TrigDecisionInterface -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigConfiguration/TrigConfData -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigConfiguration/TrigConfInterfaces -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigAnalysis/TrigInDetAnalysis -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigTruthEvent/TrigInDetTruthEvent -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_101_ATLAS_24/ROOT/6.24.06a/x86_64-centos7-gcc11-opt/include -isystem /build2/ci-builds/master/Athena/install/AthenaExternals/23.0.3/InstallArea/x86_64-centos7-gcc11-opt/include -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_101_ATLAS_24/tbb/2020_U2/x86_64-centos7-gcc11-opt/include -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_101_ATLAS_24/cppgsl/3.1.0/x86_64-centos7-gcc11-opt/include -isystem /build2/ci-builds/master/Athena/install/AthenaExternals/23.0.3/InstallArea/x86_64-centos7-gcc11-opt/lib/CLHEP-2.4.1.3/../../include -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_101_ATLAS_24/HepMC/2.06.11/x86_64-centos7-gcc11-opt/include -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_101_ATLAS_24/Boost/1.77.0/x86_64-centos7-gcc11-opt/include -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_101_ATLAS_24/eigen/3.3.7/x86_64-centos7-gcc11-opt/include/eigen3 -isystem /cvmfs/atlas.cern.ch/repo/sw/tdaq/tdaq-common/tdaq-common-04-04-00/installed/external/x86_64-centos7-gcc11-opt/include -isystem /cvmfs/atlas.cern.ch/repo/sw/tdaq/tdaq-common/tdaq-common-04-04-00/installed/include -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_101_ATLAS_24/XercesC/3.2.3/x86_64-centos7-gcc11-opt/include -fplugin=/build2/ci-builds/master/Athena/install/AthenaExternals/23.0.3/InstallArea/x86_64-centos7-gcc11-opt/lib/libchecker_gccplugins.so -DNDEBUG -O2 -Wall -Wno-long-long -Wno-deprecated -Wno-unused-local-typedefs -Wwrite-strings -Wpointer-arith -Woverloaded-virtual -Wextra -Werror=return-type -pedantic -fPIC -pthread -std=c++17 -MD -MT Trigger/TrigAnalysis/TrigInDetAnalysisUtils/CMakeFiles/TrigInDetAnalysisUtils.dir/src/TrigTrackSelector.cxx.o -MF CMakeFiles/TrigInDetAnalysisUtils.dir/src/TrigTrackSelector.cxx.o.d -o CMakeFiles/TrigInDetAnalysisUtils.dir/src/TrigTrackSelector.cxx.o -c /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigAnalysis/TrigInDetAnalysisUtils/src/TrigTrackSelector.cxx (return code: 1)
Warning: the last line does not indicate that the package build is successful

      image

  • Thomas Strebler added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Thomas Strebler added 1 commit

    added 1 commit

    • af45c104 - Remove Trk::expectBLayerHit summary values for deprecated Rec::TrackParticle

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 104K in file InnerDetector/InDetExample/InDetRecExample/python/TrackingCommon.py

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: :pushpin: build area is cleaned as MR is labeled as full-build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 19 packages:

    • InnerDetector/InDetConfig
    • InnerDetector/InDetEventCnv/InDetPrepRawDataToxAOD
    • InnerDetector/InDetExample/InDetAlignExample
    • InnerDetector/InDetExample/InDetRecExample
    • InnerDetector/InDetExample/InDetTrigRecExample
    • InnerDetector/InDetRecTools/InDetRecToolInterfaces
    • InnerDetector/InDetRecTools/InDetTestPixelLayer
    • InnerDetector/InDetRecTools/InDetTrackSelectorTool
    • InnerDetector/InDetRecTools/InDetTrackSummaryHelperTool
    • MuonSpectrometer/MuonReconstruction/MuonRecTools/MuonTrackSummaryHelperTool
    • Reconstruction/MuonIdentification/MuonCombinedBaseTools
    • Reconstruction/MuonIdentification/MuonCombinedRecExample
    • Tracking/TrkConfig
    • Tracking/TrkEvent/TrkTrackSummary
    • Tracking/TrkTools/TrkParticleCreator
    • Tracking/TrkTools/TrkToolInterfaces
    • Tracking/TrkTools/TrkTrackSummaryTool
    • Trigger/TrigAnalysis/TrigInDetAnalysisUtils
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @goetz ,@sutt ,@amorley ,@wleight ,@stavrop ,@mvozak ,@battagl ,@sroe ,@nagano ,@rosati ,@jojungge ,@apsallid ,@pscholer ,@stsuno ,@lshan ,@bernius ,@gavrilen as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash af45c104)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 55507]

  • Thomas Strebler added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Thomas Strebler removed full-build label

    removed full-build label

  • Thomas Strebler resolved all threads

    resolved all threads

  • Thomas Strebler added 506 commits

    added 506 commits

    • af45c104...73b823c3 - 498 commits from branch atlas:master
    • 1d7d0390 - Add computation of expected hit info in TrackParticleCreatorTool
    • 1a09fd0e - Disable ExpHit computation for LRT EGamma
    • 20a89fa4 - Updates for LRT
    • 3d4cbd59 - Update addExpectedHitInformation for muons vs other particles
    • 11c9c996 - Removed repeated addDetailedHitInformation
    • 3e5da81e - Restore Detector.EnablePixel protection for GSF TestPixelLayerTool
    • e5ff21dd - Remove Trk::expectBLayerHit summary values for deprecated Rec::TrackParticle
    • e1767046 - Disabled TestPixelLayerTool for InDetTrigParticleCreatorToolFTF

    Compare with previous version

    Toggle commit list
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 104K in file InnerDetector/InDetExample/InDetRecExample/python/TrackingCommon.py

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 19 packages:

    • InnerDetector/InDetConfig
    • InnerDetector/InDetEventCnv/InDetPrepRawDataToxAOD
    • InnerDetector/InDetExample/InDetAlignExample
    • InnerDetector/InDetExample/InDetRecExample
    • InnerDetector/InDetExample/InDetTrigRecExample
    • InnerDetector/InDetRecTools/InDetRecToolInterfaces
    • InnerDetector/InDetRecTools/InDetTestPixelLayer
    • InnerDetector/InDetRecTools/InDetTrackSelectorTool
    • InnerDetector/InDetRecTools/InDetTrackSummaryHelperTool
    • MuonSpectrometer/MuonReconstruction/MuonRecTools/MuonTrackSummaryHelperTool
    • Reconstruction/MuonIdentification/MuonCombinedBaseTools
    • Reconstruction/MuonIdentification/MuonCombinedRecExample
    • Tracking/TrkConfig
    • Tracking/TrkEvent/TrkTrackSummary
    • Tracking/TrkTools/TrkParticleCreator
    • Tracking/TrkTools/TrkToolInterfaces
    • Tracking/TrkTools/TrkTrackSummaryTool
    • Trigger/TrigAnalysis/TrigInDetAnalysisUtils
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @goetz ,@sutt ,@amorley ,@wleight ,@stavrop ,@mvozak ,@battagl ,@sroe ,@nagano ,@rosati ,@jojungge ,@apsallid ,@pscholer ,@stsuno ,@lshan ,@bernius ,@gavrilen as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash e1767046)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 55751]

  • Kira Abeling added review-pending-level-2 label and removed review-pending-level-1 label

    added review-pending-level-2 label and removed review-pending-level-1 label

  • Kira Abeling
    Kira Abeling @kiabelin ·
    Developer

    Changes and CI look fine from L1 point of view. However since moved cde is always hard to review passing on to L2 for a second pair of eyes cross checking the changes.

    Kira (L1)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply