MuonSimEvent: make HitIdHelpers const

Make all the Muon "HitIDHelpers" const and enable thread-checker for MuonSimEvent.

Also fixed string copy in SetStationName. Some of the other method signatures would also profit from some cleanup (e.g. pass ints by value), but I didn't touch those.

added alsoTargeting:22.0 label

This merge request affects 14 packages:

• DetectorDescription/GeoModel/GeoAdaptors
• MuonSpectrometer/MuonDigitization/CSC_Digitization
• MuonSpectrometer/MuonDigitization/MDT_Digitization
• MuonSpectrometer/MuonDigitization/MuonFastDigitization
• MuonSpectrometer/MuonDigitization/RPC_Digitization
• MuonSpectrometer/MuonDigitization/TGC_Digitization
• MuonSpectrometer/MuonG4/MuonG4SD
• MuonSpectrometer/MuonGeoModelTest
• MuonSpectrometer/MuonSimEvent
• MuonSpectrometer/MuonValidation/MuonPRDTest
• MuonSpectrometer/MuonValidation/MuonSimHitToPrdTest
• Simulation/G4Atlas/G4AtlasTests
• Simulation/ISF/ISF_Fatras/ISF_FatrasToolsMS
• Simulation/Tools/HitAnalysis

Affected files list will not be printed in this case

Adding @jchapman ,@rosati ,@wleight ,@stavrop ,@jojungge ,@tcuhadar ,@egodden ,@rbianchi ,@lmijovic as watchers

added Digitization Geometry MuonSpectrometer Simulation master review-pending-level-1 labels

CI Result SUCCESS (hash 13a0377f)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 54180]

Changes look good from L1 side - approving.

Jakub (L1 shifter)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit b6824eea

added sweep:done label

picked the changes into the branch cherry-pick-b6824eea71e-22.0 with commit 199cba2b

mentioned in commit 199cba2b

Sweep summary
successful:

• 22.0

(see https://aiatlas154.cern.ch/jenkins/job/auto_git_sweeps/2748/console for details)

mentioned in merge request !54286 (merged)

mentioned in commit aa9cb884