Support large-R UFO jets in PHYS derivation

This MR brings large-R UFO jets building to PHYS derivations.

This has been tested with :

Derivation_tf.py --CA --inputAODFile /eos/atlas/atlascerngroupdisk/perf-jets/mc20_13TeV.410470.PhPy8EG_A14_ttbar_hdamp258p75_nonallhad.recon.AOD.e6337_s3681_r13144/AOD.27120891._005893.pool.root.1 --outputDAODFile pool.root --formats PHYS

and

 Reco_tf.py --inputAODFile /eos/atlas/atlascerngroupdisk/perf-jets/mc20_13TeV.410470.PhPy8EG_A14_ttbar_hdamp258p75_nonallhad.recon.AOD.e6337_s3681_r13144/AOD.27120891._005893.pool.root.1 --outputDAODFile pool.root --reductionConf PHYS --maxEvents 100 --postExec='from DerivationFrameworkJetEtMiss.JetCommon import swapAlgsInSequence;swapAlgsInSequence(topSequence,"jetalg_ConstitModCorrectPFOCSSKCHS_GPFlowCSSK", "UFOInfoAlgCSSK" )'

Note the Reco_tf.py only works with a postExec statement because the new style config used in jet is not working smoothly with the old-style config used by this Reco_tf.py command. I'm not sure there's a simpler way than using a postExec. Probably @jcatmore can tell if this is acceptable ?

Also tagging @cdelitzs @mswiatlo @camacho @mspalla @haweber

added Derivation JetEtmiss labels

assigned to @delsart

marked this merge request as ready

changed the description

This merge request affects 6 packages:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkConfiguration
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkPhys
• Reconstruction/Jet/JetMomentTools
• Reconstruction/Jet/JetRecConfig
• Reconstruction/TrackCaloClusterRec/TrackCaloClusterRecTools

Affected files list will not be printed in this case

Adding @zmarshal ,@goetz ,@jmellent ,@jveatch ,@ispokhar ,@dshope ,@nelsonc ,@cantel as watchers

added Reconstruction analysis-review-required master review-pending-level-1 labels

added NewConfig label

Hi,

for me, it is fine to have the pre-exec for the legacy version, because it will only be in use for a short time, but I leave @calpigia to have the final word. The CA version looks good.

Cheers,

James.

approved this merge request

CI Result FAILURE (hash db9f5c9c)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 54500]

@delsart @cdelitzs Can we also add these to e.g. JETM1/3/etc.? Or is that coming up in a next MR?

Thank you so so so much!

Best, Max

Hi,

The failing CI tests are those building DAOD_PHYS with Reco_tf.py : they need a postExec as explained above. If it is ok to have these postExec, does someone knows in which package they are defined ?

@mswiatlo I can probably add them to this MR, @cdelitzs can you remind me in which file these should happen and command lines to test it works ?

Cheers,

P-A

Hello,

no objections with going ahead with the postExec for the legacy version.

Cristiano

Hi @delsart ,

Thanks so much for fixing this issue!!!

I think the UFO jets should be in JETM1 after your MR because we added the jet collection already to the smart slimming list and we're importing PhysCommon where those jets are reconstructed.

For JETM3, you would need simply need to add the jets to the smart slimming list here

This is all running with the legacy version (Reco_tf) ... we haven't migrated the JETMX derivations yet to the CA version. I was planning on starting with this next week.

The command to test this is the usual one (you just need to replace the reductionConf accordingly and add your postExec)

Reco_tf.py --inputAODFile /eos/atlas/atlascerngroupdisk/perf-jets/mc20_13TeV.410470.PhPy8EG_A14_ttbar_hdamp258p75_nonallhad.recon.AOD.e6337_s3681_r13144/AOD.27120891._005893.pool.root.1 --outputDAODFile pool.root --reductionConf JETM1 --maxEvents 100

Cheers, Chris

Setting review-user-action-required until failing CI tests are addressed.

Jakub (L1 shifter)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 7759a3dd - fix Reco_tf CI tests for UFO jets

Compare with previous version

This merge request affects 7 packages:

• AtlasTest/CITest
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkConfiguration
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkPhys
• Reconstruction/Jet/JetMomentTools
• Reconstruction/Jet/JetRecConfig
• Reconstruction/TrackCaloClusterRec/TrackCaloClusterRecTools

Affected files list will not be printed in this case

Adding @zmarshal ,@goetz ,@jmellent ,@jveatch ,@ispokhar ,@dshope ,@fwinkl ,@nelsonc ,@cantel as watchers

added Test review-pending-level-1 labels and removed review-user-action-required label

CI Result FAILURE (hash 7759a3dd)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 54532]