Skip to content
Snippets Groups Projects

fix AFP pixel numbering and particle propagation

Merged fix AFP pixel numbering and particle propagation
pbalek/athena:afp-fix-pixel-numbers into master
Merged Petr Balek requested to merge pbalek/athena:afp-fix-pixel-numbers into master

AFP pixel numbers should be from 0-79 and 0-335, as expected in AFP_PileUpTool. Here, we make pixels with numbers 1-80 and 1-336 if particle crosses pixel borders such that Y index increases/decreases.

Also fixing several bugs in particle propagation - position was updated only for one coordinate and in rare occasions it could be set totally off.

Finally, removes #defines and replaces them with static constexpr.

I'm not sure if violation of frozen tier-0 policy applies here. The output does change but this code isn't used for any data reconstruction...

Tagging @ladamczy

Closes AFPSOFT-139

Edited by Petr Balek

Merge request reports

Pipeline #4183483 passed

Stage: external

Pipeline passed for 6e003d22 on pbalek:afp-fix-pixel-numbers

Approval is optional

Merged by Walter LamplWalter Lampl 2 years ago (Jul 5, 2022 8:43am UTC)

Merge details

  • Changes merged into master with c0a27c5d (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply