introduce a new set of ASG test files (ATLASG-1636)

This is now an extended set of files to cover the different kinds of files we may use as input in analysis.

I did fix up relevant tests as far as I could, but had to disable the electron-DNN tests temporarily, as that is apparently not supported on DAOD_PHYS (yet).

This contains a fix to e-gamma tools which avoids an endless recursion in some cases, and avoids repeated look-ups of the EventContext at the same.

This is needed in 22.0 (as well as master), as we have tests/MRs in 22.0 that fail because the current input files are too old.

added full-unit-tests + 1 deleted label

This merge request affects 1 package:

• AsgExternal/Asg_Test

This merge request affects 9 files:

• AsgExternal/Asg_Test/CMakeLists.txt
• AsgExternal/Asg_Test/cmake/Asg_TestEnvironmentConfig.cmake.in
• AsgExternal/Asg_Test/cmt/TestFileData.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteData.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteMC.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteMCAFII.txt
• AsgExternal/Asg_Test/cmt/TestFileMC.txt
• AsgExternal/Asg_Test/cmt/TestFileMCAFII.txt
• AsgExternal/Asg_Test/cmt/TestFileR3MC.txt

Could not map the following files to a domain:

• AsgExternal/Asg_Test/cmake/Asg_TestEnvironmentConfig.cmake.in
• AsgExternal/Asg_Test/CMakeLists.txt
• AsgExternal/Asg_Test/cmt/TestFileData.txt
• AsgExternal/Asg_Test/cmt/TestFileMCAFII.txt
• AsgExternal/Asg_Test/cmt/TestFileR3MC.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteMCAFII.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteMC.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteData.txt
• AsgExternal/Asg_Test/cmt/TestFileMC.txt

added analysis-review-required master no-domain review-pending-level-1 labels

added Analysis label

CI Result FAILURE (hash 08085195)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 54914]

changed the description

Hi @krumnack,

to speed up the MR urgently needed by MCP wouldn't it be better that you target these changes to 22.0 rather than master? Also, I see that you've just added ~"alsoTargeting:master" instead of alsoTargeting:22.0. Is this a mistake?

Tagging the MCP conveners @mvanadia, @gabarone

changed target branch from master to 22.0

removed master label

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

I thought that's what I had done. My mistake. Updated the target now, and will hopefully fix the tests in a little bit.

This merge request affects 1 package:

• AsgExternal/Asg_Test

This merge request affects 9 files:

• AsgExternal/Asg_Test/CMakeLists.txt
• AsgExternal/Asg_Test/cmake/Asg_TestEnvironmentConfig.cmake.in
• AsgExternal/Asg_Test/cmt/TestFileData.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteData.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteMC.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteMCAFII.txt
• AsgExternal/Asg_Test/cmt/TestFileMC.txt
• AsgExternal/Asg_Test/cmt/TestFileMCAFII.txt
• AsgExternal/Asg_Test/cmt/TestFileR3MC.txt

Could not map the following files to a domain:

• AsgExternal/Asg_Test/cmake/Asg_TestEnvironmentConfig.cmake.in
• AsgExternal/Asg_Test/CMakeLists.txt
• AsgExternal/Asg_Test/cmt/TestFileData.txt
• AsgExternal/Asg_Test/cmt/TestFileMCAFII.txt
• AsgExternal/Asg_Test/cmt/TestFileR3MC.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteMCAFII.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteMC.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteData.txt
• AsgExternal/Asg_Test/cmt/TestFileMC.txt

added 22.0 label

added 1 commit

• 0e1d3ee2 - introduce a new set of ASG test files

Compare with previous version

This merge request affects 6 packages:

• AsgExternal/Asg_Test
• Control/xAODDataSource
• Control/xAODRootAccess
• PhysicsAnalysis/Algorithms/EgammaAnalysisAlgorithms
• PhysicsAnalysis/ElectronPhotonID/ElectronEfficiencyCorrection
• PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools

Affected files list will not be printed in this case

Could not map the following files to a domain:

• AsgExternal/Asg_Test/cmake/Asg_TestEnvironmentConfig.cmake.in
• AsgExternal/Asg_Test/CMakeLists.txt
• AsgExternal/Asg_Test/cmt/TestFileData.txt
• AsgExternal/Asg_Test/cmt/TestFileMCAFII.txt
• AsgExternal/Asg_Test/cmt/TestFileR3MC.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteMCAFII.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteMC.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteData.txt
• AsgExternal/Asg_Test/cmt/TestFileMC.txt

Adding @krumnack ,@tadej ,@akraszna ,@ssnyder ,@pagessin as watchers

added Core Derivation Egamma JetEtmiss labels

changed the description

CI Result FAILURE (hash 08085195)

	Athena	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 55004]

added analysis-review-approved label and removed analysis-review-required label

CI Result FAILURE (hash 0e1d3ee2)

	Athena	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 55017]

The following tests FAILED:
	568 - xAODDataSource_dataSourceEvent_test_ctest (Failed)
	569 - xAODDataSource_dataSource_test_ctest (Failed)
	570 - xAODDataSource_dataFrame_test_ctest (Failed)
	571 - xAODDataSource_dataFrameTypeConversion_test_ctest (Failed)
	572 - xAODDataSource_dataFrameElementLink_test_ctest (Failed)
	573 - xAODDataSource_dataFrame_pytest_ctest (Failed)
	1327 - MuonConfig_MuonDataDecodeTest_ctest (Failed)
	1328 - MuonConfig_MuonDataDecodeTest_Cache_ctest (Failed)
[ERROR_MESSAGE]

Can you please check?

The MuonConfig errors are also in the nightlies from what I can tell. The xAODDataSource I can hopefully fix.

MuonConfig is on my plate

added 111 commits

• 0e1d3ee2...639b1555 - 110 commits from branch atlas:22.0
• b95a72c4 - introduce a new set of ASG test files

Compare with previous version

This merge request affects 6 packages:

• AsgExternal/Asg_Test
• Control/xAODDataSource
• Control/xAODRootAccess
• PhysicsAnalysis/Algorithms/EgammaAnalysisAlgorithms
• PhysicsAnalysis/ElectronPhotonID/ElectronEfficiencyCorrection
• PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools

Affected files list will not be printed in this case

Could not map the following files to a domain:

• AsgExternal/Asg_Test/cmake/Asg_TestEnvironmentConfig.cmake.in
• AsgExternal/Asg_Test/CMakeLists.txt
• AsgExternal/Asg_Test/cmt/TestFileData.txt
• AsgExternal/Asg_Test/cmt/TestFileMCAFII.txt
• AsgExternal/Asg_Test/cmt/TestFileR3MC.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteMCAFII.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteMC.txt
• AsgExternal/Asg_Test/cmt/TestFileLiteData.txt
• AsgExternal/Asg_Test/cmt/TestFileMC.txt

Adding @krumnack ,@tadej ,@akraszna ,@ssnyder ,@pagessin as watchers

        1327 - MuonConfig_MuonDataDecodeTest_ctest (Failed)
	1328 - MuonConfig_MuonDataDecodeTest_Cache_ctest (Failed)

will be fixed in !54744 (merged)

CI Result FAILURE (hash b95a72c4)

	Athena	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 55072]

The test failures are unrelated.

Hi @jojungge,

If you feel this is urgent for you, please feel free to add the proper flags. I don't know how urgently you need it.

Cheers, Nils

Changes look fine to me. Sending on to L2 due to the number of changes and the failing CI. Clara (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

added urgent label

added urgent label since this is blocking !54430 (merged) which is urgent for MCP

added review-approved label and removed review-pending-level-2 label

All good, with the understanding that the test failures are addressed in !54744 (merged).

Karolos (L2)

added review-approved-point1 label

This touches PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools/Root/AsgElectronSelectorTool.cxx can you mention the fix in the description @krumnack?

added review-approved-tier0 label

changed the description

resolved all threads

merged

mentioned in commit 186bb467

mentioned in merge request !54430 (merged)

mentioned in merge request !54847 (merged)

mentioned in merge request !54879 (merged)

mentioned in commit dbc1425e