Skip to content
Snippets Groups Projects

LArG4H6SD: enable thread-checker and fixes

Merged LArG4H6SD: enable thread-checker and fixes
fwinkl/athena:larg4h6sd into master
All threads resolved!
Merged Frank Winklmeier requested to merge fwinkl/athena:larg4h6sd into master
All threads resolved!
  • replace statics with locals
  • const fixes
  • remove unnecessary new/delete operators
  • use const static initialization

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Frank Winklmeier added 1 commit

    added 1 commit

    • 1f31cddc - LArG4H6SD: enable thread-checker and fixes

    Compare with previous version

  • Frank Winklmeier resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • LArCalorimeter/LArG4/LArG4H6SD

    This merge request affects 11 files:

    • LArCalorimeter/LArG4/LArG4H6SD/ATLAS_CHECK_THREAD_SAFETY
    • LArCalorimeter/LArG4/LArG4H6SD/src/LArFCALH62004CalibCalculatorBase.cc
    • LArCalorimeter/LArG4/LArG4H6SD/src/LArG4H62004DeadCalibrationCalculator.cc
    • LArCalorimeter/LArG4/LArG4H6SD/src/LArG4H6BeamSD.cc
    • LArCalorimeter/LArG4/LArG4H6SD/src/LArG4H6WarmTCSD.cc
    • LArCalorimeter/LArG4/LArG4H6SD/src/LArG4TBECBeamChHit.h
    • LArCalorimeter/LArG4/LArG4H6SD/src/LArGeoH62004EventAction.cc
    • LArCalorimeter/LArG4/LArG4H6SD/src/LArGeoH62004EventAction.h
    • LArCalorimeter/LArG4/LArG4H6SD/src/LArGeoH62004SteppingAction.cc
    • LArCalorimeter/LArG4/LArG4H6SD/src/RadLenNtuple.cc
    • LArCalorimeter/LArG4/LArG4H6SD/src/RadLenNtuple.h

    Adding @pavol as watcher

  • ATLAS Robot added review-pending-level-1 label and removed review-approved label

    added review-pending-level-1 label and removed review-approved label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 1f31cddc)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 55021]

  • Frank Winklmeier
    Frank Winklmeier @fwinkl ·
    Author Maintainer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • LArCalorimeter/LArG4/LArG4H6SD

    This merge request affects 11 files:

    • LArCalorimeter/LArG4/LArG4H6SD/ATLAS_CHECK_THREAD_SAFETY
    • LArCalorimeter/LArG4/LArG4H6SD/src/LArFCALH62004CalibCalculatorBase.cc
    • LArCalorimeter/LArG4/LArG4H6SD/src/LArG4H62004DeadCalibrationCalculator.cc
    • LArCalorimeter/LArG4/LArG4H6SD/src/LArG4H6BeamSD.cc
    • LArCalorimeter/LArG4/LArG4H6SD/src/LArG4H6WarmTCSD.cc
    • LArCalorimeter/LArG4/LArG4H6SD/src/LArG4TBECBeamChHit.h
    • LArCalorimeter/LArG4/LArG4H6SD/src/LArGeoH62004EventAction.cc
    • LArCalorimeter/LArG4/LArG4H6SD/src/LArGeoH62004EventAction.h
    • LArCalorimeter/LArG4/LArG4H6SD/src/LArGeoH62004SteppingAction.cc
    • LArCalorimeter/LArG4/LArG4H6SD/src/RadLenNtuple.cc
    • LArCalorimeter/LArG4/LArG4H6SD/src/RadLenNtuple.h

    Adding @pavol as watcher

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 1f31cddc)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 55070]

  • Fang-Ying Tsai
    Fang-Ying Tsai @fatsai ·
    Developer

    Changes and CI are looking good. - L1

  • Fang-Ying Tsai removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Fang-Ying Tsai added review-approved label

    added review-approved label

  • Adam Edward Barton mentioned in commit 609cac71

    mentioned in commit 609cac71

  • Adam Edward Barton merged

    merged

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply