GoodRunsLists: thread-safety fixes and code cleanup

The main change is to remove the thread-unsafe caching of the previous run and LB number in TGoodRunsList::HasRun[LumiBlock]. If the std::map lookup is really too slow we need to implement this properly.

Also modernize the code (e.g. rely on compiler generated copy/assignment) and enable the thread-checker. The latter also required a few extra annotations in LumiCalc.

Not sure who is responsible for this package these days. Tagging a few experts: @tadej @krumnack @ponyisi @akraszna

added alsoTargeting:22.0 label

assigned to @fwinkl

This merge request affects 2 packages:

• DataQuality/GoodRunsLists
• LumiBlock/LumiCalc

Affected files list will not be printed in this case

added DQ analysis-review-required master review-pending-level-1 labels

CI Result SUCCESS (hash 91844e64)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 54963]

added review-pending-expert label

removed review-pending-level-1 label

removed review-pending-expert label

added review-pending-level-1 label

added review-pending-level-2 label

removed review-pending-level-1 label

I do not see any problems, but it involves many changes so I'd pass it to our L2 shifter. --L1

added review-approved label and removed review-pending-level-2 label

Looks good. Karolos (L2)

added analysis-review-approved label and removed analysis-review-required label

merged

mentioned in commit 19f72a38

added sweep:done label

picked the changes into the branch cherry-pick-19f72a38586-22.0 with commit f0102f3d

mentioned in commit f0102f3d

Sweep summary
successful:

• 22.0

(see https://aiatlas154.cern.ch/jenkins/job/auto_git_sweeps/2817/console for details)

mentioned in merge request !54792 (merged)

mentioned in commit ac664921