ISF_Interfaces: add const-correct StoreGate accessors and remove mutable

Enable thread-checker and fix warnings.

assigned to @fwinkl

This merge request affects 1 package:

• Simulation/ISF/ISF_Core/ISF_Interfaces

This merge request affects 2 files:

• Simulation/ISF/ISF_Core/ISF_Interfaces/ISF_Interfaces/ATLAS_CHECK_THREAD_SAFETY
• Simulation/ISF/ISF_Core/ISF_Interfaces/ISF_Interfaces/BaseSimulationSvc.h

Adding @jchapman as watcher

added Simulation master review-pending-level-1 labels

CI Result SUCCESS (hash cf46fcd2)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 55003]

added review-approved label and removed review-pending-level-1 label

Changes and CI look fine. Approving.

Kira (L1)

merged

mentioned in commit 779444ae

added sweep:ignore label