Skip to content
Snippets Groups Projects

Synchronise CA with old-style config, and fix some mistakes

Merged Synchronise CA with old-style config, and fix some mistakes
emoyse/athena:22.0_yet_more_CA_synch_fixes_4 into 22.0
Merged Edward Moyse requested to merge emoyse/athena:22.0_yet_more_CA_synch_fixes_4 into 22.0

This MR is another attempt to reduce the output differences when running CA compared to old-style configuration. Since this is not on by default, it will have no impact on existing prodcution.

I tested this locally with the q445 test (link) and this reduces the difference from (r10):

Summary of differences:
nMuons: 2 events (out of 100)
muon1pt: 13 events (out of 100)
muon1eta: 5 events (out of 100)
muon1phi: 5 events (out of 100)

to:

muon1pt: 12 events (out of 100)
muon1eta: 3 events (out of 100)
muon1phi: 3 events (out of 100)

The MR contains the following types of commits.

  • Fix naming of various tools to match old-style
  • Set Cosmics correctly in MuidCaloEnergyToolParamCfg
  • Cleanup use of MuonTrackCleanerCfg and MCTBSLFitterCfg
  • Fix for MuidCaloEnergyParam calling wrong tool
  • In MuonExtrapolatorConfig, we only need one import of AtlasSTEP_PropagatorCfg
  • MuonRefitToolCfg should use MCTBFitterMaterialFromTrackCfg
  • MCTBFitterCfg should have GetMaterialFromTrack True

cc @elmsheus @nstyles @goetz @mhodgkin

Edited by Edward Moyse

Merge request reports

Pipeline #4224063 passed

Stage: external

Pipeline passed for a596a650 on emoyse:22.0_yet_more_CA_synch_fixes_4

Approval is optional

Merged by Julien MaurerJulien Maurer 2 years ago (Jul 13, 2022 1:49pm UTC)

Merge details

  • Changes merged into 22.0 with 68c60d85 (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply