Synchronise CA with old-style config, and fix some mistakes : part 2

This MR is another attempt to reduce the output differences when running CA compared to old-style configuration. Since this is not on by default, it will have no impact on existing production.

It should not be merged until !54998 (merged) is in, since it depends on commits in this MR.

I tested this locally with the q445 test (link) and this reduces the difference from !54998 (merged) to:

muon1pt: 8 events (out of 100)
muon1eta: 1 events (out of 100)
muon1phi: 2 events (out of 100)

The MR contains the following types of commits.

• Fix naming of various tools to match old-style
• Set Cosmics correctly in MuidCaloEnergyToolParamCfg
• Cleanup use of MuonTrackCleanerCfg and MCTBSLFitterCfg
• Fix for MuidCaloEnergyParam calling wrong tool
• In MuonExtrapolatorConfig, we only need one import of AtlasSTEP_PropagatorCfg
• MuonRefitToolCfg should use MCTBFitterMaterialFromTrackCfg
• MCTBFitterCfg should have GetMaterialFromTrack True

Edit: closed and reopened to fix the branch to merge into!

added NewConfig label

assigned to @emoyse

marked this merge request as ready

closed

changed target branch from master to 22.0

reopened

changed the description

changed title from Synchronise CA with old-style config, and fix some mistakes to Synchronise CA with old-style config, and fix some mistakes : part 2

This merge request affects 6 packages:

• Event/xAOD/xAODMuonCnv
• MuonSpectrometer/MuonConfig
• Reconstruction/MuonIdentification/MuonCombinedAlgs
• Reconstruction/MuonIdentification/MuonCombinedConfig
• Reconstruction/RecoTools/TrackToCalo
• Tracking/TrkConfig

Affected files list will not be printed in this case

Adding @goetz ,@rosati ,@wleight ,@stavrop ,@gavrilen ,@amorley ,@jojungge ,@apsallid ,@akraszna ,@pscholer as watchers

added 22.0 EDM Egamma MuonSpectrometer Reconstruction Tracking review-pending-level-1 labels

CI Result FAILURE (hash f74ff1e6)

	Athena	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 55648]

 noerror.sh> ERROR: Found the following errors in TriggerDataCAConfig.log:
2022-07-12T151236 CEST TrigValSteering ERROR    Step failure while running in CI. Printing partial log athena_run.log
ToolSvc.MuonStraightLineExtrapolator                                      20     0   ERROR No job properties found. This is not allowed for an AthCheckedComponent.
ToolSvc.MuonStraightLineExtrapolator                                      20     0   ERROR /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/22.0/Control/AthenaBaseComps/AthenaBaseComps/AthCheckedComponent.icc:15 (StatusCode AthCheckedComponent<PBASE>::sysInitialize() [with PBASE = AthAlgTool]): code FAILURE: isConfigured()
ToolSvc                                                                   20     0   ERROR Error initializing tool 'ToolSvc.MuonStraightLineExtrapolator'
TrigMuPatTrackBuilder_RoI                                                 20     0   FATAL  Exception with tag=PublicTool retrieve is caught 
TrigMuPatTrackBuilder_RoI                                                 20     0   ERROR PublicTool retrieve 	 Failed to retrieve PublicTool: Trk::Extrapolator/MuonStraightLineExtrapolator	 StatusCode=FAILURE
AlgTask                                                                   20     0   FATAL .executeEvent(): Exception with tag=PublicTool retrieve thrown by TrigMuPatTrackBuilder_RoI
AlgTask                                                                   20     0   ERROR PublicTool retrieve 	 Failed to retrieve PublicTool: Trk::Extrapolator/MuonStraightLineExtrapolator	 StatusCode=FAILURE
AvalancheSchedulerSvc                                                     20     0   ERROR *** Stall detected in slot 0! ***
AvalancheSchedulerSvc                                                     20     0   ERROR Event 20 on slot 0 failed
ERROR alg(s): in subslot(s)
ERROR alg(s):
ERROR alg(s):
ERROR alg(s): TrigMuPatTrackBuilder_RoI
AthenaHiveEventLoopMgr                                                               FATAL Failed event detected on s: 0  e: 20 w/ fail mode: AlgStall
Py:ComponentAccumulator   ERROR Failure running application
ToolSvc.MuonStraightLineExtrapolator                                      20     0   ERROR No job properties found. This is not allowed for an AthCheckedComponent.
ToolSvc.MuonStraightLineExtrapolator                                      20     0   ERROR /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/22.0/Control/AthenaBaseComps/AthenaBaseComps/AthCheckedComponent.icc:15 (StatusCode AthCheckedComponent<PBASE>::sysInitialize() [with PBASE = AthAlgTool]): code FAILURE: isConfigured()
ToolSvc                                                                   20     0   ERROR Error initializing tool 'ToolSvc.MuonStraightLineExtrapolator'
TrigMuPatTrackBuilder_RoI                                                 20     0   FATAL  Exception with tag=PublicTool retrieve is caught 
TrigMuPatTrackBuilder_RoI                                                 20     0   ERROR PublicTool retrieve 	 Failed to retrieve PublicTool: Trk::Extrapolator/MuonStraightLineExtrapolator	 StatusCode=FAILURE
AlgTask                                                                   20     0   FATAL .executeEvent(): Exception with tag=PublicTool retrieve thrown by TrigMuPatTrackBuilder_RoI
AlgTask                                                                   20     0   ERROR PublicTool retrieve 	 Failed to retrieve PublicTool: Trk::Extrapolator/MuonStraightLineExtrapolator	 StatusCode=FAILURE
AvalancheSchedulerSvc                                                     20     0   ERROR *** Stall detected in slot 0! ***
AvalancheSchedulerSvc                                                     20     0   ERROR Event 20 on slot 0 failed
ERROR alg(s): in subslot(s)
ERROR alg(s):
ERROR alg(s):
ERROR alg(s): TrigMuPatTrackBuilder_RoI
AthenaHiveEventLoopMgr                                                               FATAL Failed event detected on s: 0  e: 20 w/ fail mode: AlgStall
Py:ComponentAccumulator   ERROR Failure running application
2022-07-12T151239 CEST TrigValSteering ERROR    Skipping step MessageCount because previous step(s) failed
 noerror.sh> ERROR: Test TriggerDataCAConfig failed with exit code: 10
 noerror.sh> Please check /build/ci-builds/22.0/Athena/build/Athena/AtlasTest/CITest/CMakeFiles/ciTestRun/TriggerDataCAConfig/TriggerDataCAConfig.log

that one is real, I am afraid.

removed review-pending-level-1 label

added review-user-action-required label

It is, and I have a strong suspicion I know where it comes from.

added 2 commits

• 8de40d7f - Synchronise CA with old-style config, and fix some mistakes
• 2cc0e98b - Need to disable UseOnlyHitSectors in from ESD test due to missing HoughDataPerSectorVec

Compare with previous version

This merge request affects 6 packages:

• Event/xAOD/xAODMuonCnv
• MuonSpectrometer/MuonConfig
• Reconstruction/MuonIdentification/MuonCombinedAlgs
• Reconstruction/MuonIdentification/MuonCombinedConfig
• Reconstruction/RecoTools/TrackToCalo
• Tracking/TrkConfig

Affected files list will not be printed in this case

Adding @goetz ,@rosati ,@wleight ,@stavrop ,@gavrilen ,@amorley ,@jojungge ,@apsallid ,@akraszna ,@pscholer as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 2cc0e98b)

	Athena	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 55733]

removed review-pending-level-1 label

added review-approved label

added 117 commits

• 2cc0e98b...fcff4347 - 117 commits from branch atlas:22.0

Compare with previous version

This merge request affects no known files AND packages. Consult an expert!

This merge request affects 0 files:

added no-domain review-pending-level-1 labels and removed review-approved label

Er... it looks like I messed up my rebase. Ooops.

added 1 commit

• ed27b74c - Synchronise CA with old-style config, and fix some mistakes

Compare with previous version

This merge request affects 3 packages:

• MuonSpectrometer/MuonConfig
• Reconstruction/MuonIdentification/MuonCombinedConfig
• Tracking/TrkConfig

Affected files list will not be printed in this case

Adding @goetz ,@rosati ,@wleight ,@stavrop ,@amorley ,@jojungge ,@apsallid ,@pscholer as watchers

CI Result SUCCESS (hash fcff4347)

	Athena	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 55761]

CI Result SUCCESS (hash ed27b74c)

	Athena	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 55762]

added review-approved label

removed review-pending-level-1 label

added review-approved-tier0 label

merged

mentioned in commit cc88f973