23.0-cppcheck-VP1Systems

Some cppcheck fixes; one shadowed variable, string and vector changed from pass by value to pass by const ref. Post increment changed to pre increment for iterators. Some (small) header cleanup along the way.

assigned to @sroe

This merge request affects 4 packages:

• graphics/VP1/VP1Systems/VP1AODSystems
• graphics/VP1/VP1Systems/VP1BPhysSystems
• graphics/VP1/VP1Systems/VP1GuideLineSystems
• graphics/VP1/VP1Systems/VP1PRDSystems

Affected files list will not be printed in this case

Adding @rbianchi as watcher

added EventDisplay master review-pending-level-1 labels

CI Result SUCCESS (hash ce31095e)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 55849]

Changes look good, CI is passing - approving.

L1 shifter

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit b36856c7

added sweep:ignore label