TrkAlignGenTools: enable thread-checker and fixes

Mostly trivial const/mutable fixes.

assigned to @fwinkl

This merge request affects 1 package:

• Tracking/TrkAlignment/TrkAlignGenTools

This merge request affects 11 files:

• Tracking/TrkAlignment/TrkAlignGenTools/TrkAlignGenTools/ATLAS_CHECK_THREAD_SAFETY
• Tracking/TrkAlignment/TrkAlignGenTools/TrkAlignGenTools/AlignModuleTool.h
• Tracking/TrkAlignment/TrkAlignGenTools/TrkAlignGenTools/AlignResidualCalculator.h
• Tracking/TrkAlignment/TrkAlignGenTools/TrkAlignGenTools/AlignTrackCreator.h
• Tracking/TrkAlignment/TrkAlignGenTools/TrkAlignGenTools/AlignTrackDresser.h
• Tracking/TrkAlignment/TrkAlignGenTools/TrkAlignGenTools/AnalyticalDerivCalcTool.h
• Tracking/TrkAlignment/TrkAlignGenTools/src/AlignModuleTool.cxx
• Tracking/TrkAlignment/TrkAlignGenTools/src/AlignResidualCalculator.cxx
• Tracking/TrkAlignment/TrkAlignGenTools/src/AlignTrackDresser.cxx
• Tracking/TrkAlignment/TrkAlignGenTools/src/AnalyticalDerivCalcTool.cxx
• Tracking/TrkAlignment/TrkAlignGenTools/src/ShiftingDerivCalcTool.cxx

Adding @amorley as watcher

added Tracking master review-pending-level-1 labels

CI Result SUCCESS (hash 84025149)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 55852]

Changes look good, CI passed - approving.

L1 shifter

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 4b184d11

added sweep:ignore label