Skip to content
Snippets Groups Projects

TrkAlgebraUtils: enable thread-checker and fixes

Merged Frank Winklmeier requested to merge fwinkl/athena:trkalgebra into master

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • assigned to @fwinkl

  • This merge request affects 1 package:

    • Tracking/TrkAlignment/TrkAlgebraUtils

    This merge request affects 6 files:

    • Tracking/TrkAlignment/TrkAlgebraUtils/TrkAlgebraUtils/ATLAS_CHECK_THREAD_SAFETY
    • Tracking/TrkAlignment/TrkAlgebraUtils/TrkAlgebraUtils/AlMat.h
    • Tracking/TrkAlignment/TrkAlgebraUtils/TrkAlgebraUtils/AlSymMat.h
    • Tracking/TrkAlignment/TrkAlgebraUtils/TrkAlgebraUtils/AlVec.h
    • Tracking/TrkAlignment/TrkAlgebraUtils/TrkAlgebraUtils/IPCMat.h
    • Tracking/TrkAlignment/TrkAlgebraUtils/src/IPCMat.cxx

    Adding @amorley as watcher

  • :negative_squared_cross_mark: CI Result FAILURE

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :o: :white_check_mark: :white_check_mark:
    cmake N/A N/A N/A N/A N/A N/A
    make N/A N/A N/A N/A N/A N/A
    required tests N/A N/A N/A N/A N/A N/A
    optional tests N/A N/A N/A N/A N/A N/A

    :exclamation: Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 55854]

  • Author Maintainer

    Jenkins please retry a build

  • This merge request affects 1 package:

    • Tracking/TrkAlignment/TrkAlgebraUtils

    This merge request affects 6 files:

    • Tracking/TrkAlignment/TrkAlgebraUtils/TrkAlgebraUtils/ATLAS_CHECK_THREAD_SAFETY
    • Tracking/TrkAlignment/TrkAlgebraUtils/TrkAlgebraUtils/AlMat.h
    • Tracking/TrkAlignment/TrkAlgebraUtils/TrkAlgebraUtils/AlSymMat.h
    • Tracking/TrkAlignment/TrkAlgebraUtils/TrkAlgebraUtils/AlVec.h
    • Tracking/TrkAlignment/TrkAlgebraUtils/TrkAlgebraUtils/IPCMat.h
    • Tracking/TrkAlignment/TrkAlgebraUtils/src/IPCMat.cxx

    Adding @amorley as watcher

  • :white_check_mark: CI Result SUCCESS (hash 9c3d001c)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 55867]

  • Straightforward changes to add const function to return const type, but no description. Maybe the title is enough(?), so will mark approved to avoid undue delay and let RC reject if deception is needed. ~Joe (L2)

  • added review-approved label and removed review-pending-level-1 label

  • Tadej Novak mentioned in commit 355cb315

    mentioned in commit 355cb315

  • merged

Please register or sign in to reply
Loading