From c7dc5709e868831f8295d1a7881c78e55ae7a402 Mon Sep 17 00:00:00 2001 From: scott snyder <snyder@bnl.gov> Date: Sun, 17 Jul 2022 19:35:08 +0200 Subject: [PATCH 1/2] NSWCalibTools: Fix clang warnings. Missing override keywords. --- .../NSWCalib/NSWCalibTools/src/NSWCalibSmearingTool.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MuonSpectrometer/MuonCalib/NSWCalib/NSWCalibTools/src/NSWCalibSmearingTool.h b/MuonSpectrometer/MuonCalib/NSWCalib/NSWCalibTools/src/NSWCalibSmearingTool.h index e61e35036bcd..acb8bcc354b2 100644 --- a/MuonSpectrometer/MuonCalib/NSWCalib/NSWCalibTools/src/NSWCalibSmearingTool.h +++ b/MuonSpectrometer/MuonCalib/NSWCalib/NSWCalibTools/src/NSWCalibSmearingTool.h @@ -1,5 +1,5 @@ /* - Copyright (C) 2002-2021 CERN for the benefit of the ATLAS collaboration + Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration */ #ifndef NSWCalibSmearingTool_h @@ -29,16 +29,16 @@ namespace Muon { virtual ~NSWCalibSmearingTool() {}; - virtual StatusCode initialize(); + virtual StatusCode initialize() override; - StatusCode isAccepted(const Identifier id, bool& accepted, CLHEP::HepRandomEngine* rndmEngine) const ; + virtual StatusCode isAccepted(const Identifier id, bool& accepted, CLHEP::HepRandomEngine* rndmEngine) const override; double getHighVoltage(Identifier id) const; StatusCode smearTimeAndCharge(const Identifier id, float& time, float& charge, bool& accepted, CLHEP::HepRandomEngine* rndmEngine) const override; StatusCode smearCharge(const Identifier id, float& charge, bool& accepted, CLHEP::HepRandomEngine* rndmEngine) const override; - StatusCode getGainFraction(const Identifier id, float& charge); + virtual StatusCode getGainFraction(const Identifier id, float& charge) override; private: -- GitLab From c606b712b416c41f91f2d7408516990ba4ae8aff Mon Sep 17 00:00:00 2001 From: scott snyder <snyder@bnl.gov> Date: Sun, 17 Jul 2022 19:24:12 +0200 Subject: [PATCH 2/2] TrkAlignGenTools: Fix clang warnings. Missing override keywords. --- .../TrkAlignGenTools/TrkAlignGenTools/AlignTrackDresser.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Tracking/TrkAlignment/TrkAlignGenTools/TrkAlignGenTools/AlignTrackDresser.h b/Tracking/TrkAlignment/TrkAlignGenTools/TrkAlignGenTools/AlignTrackDresser.h index cc481198433a..f132107b411b 100644 --- a/Tracking/TrkAlignment/TrkAlignGenTools/TrkAlignGenTools/AlignTrackDresser.h +++ b/Tracking/TrkAlignment/TrkAlignGenTools/TrkAlignGenTools/AlignTrackDresser.h @@ -40,13 +40,13 @@ namespace Trk { virtual StatusCode finalize() override; /** dresses alignTrack with derivatives and other information */ - bool dressAlignTrack(AlignTrack * alignTrack); + virtual bool dressAlignTrack(AlignTrack * alignTrack) override; /** sets residuals for TSOS on alignTrack */ void setResiduals(AlignTrack * alignTrack) const; /** sets the output stream for the logfile */ - virtual void setLogStream(std::ostream * os); + virtual void setLogStream(std::ostream * os) override; private: -- GitLab