23.0-cppcheck-Herwig7_i

[minor] Clear cppcheck warning about invalid iteration by using a for_each algorithm. Also tidied headers slightly.

assigned to @sroe

This merge request affects 1 package:

• Generators/Herwig7_i

This merge request affects 2 files:

• Generators/Herwig7_i/Herwig7_i/PowhegLesHouchesFileReader.h
• Generators/Herwig7_i/src/PowhegLesHouchesFileReader.cxx

added Generators master review-pending-level-1 labels

The system determined that CI tests (with names matching "^CITest_Trigger.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 8e744aac)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 56610]

added review-user-action-required label and removed review-pending-level-1 label

resolved all threads

added 1 commit

• 94a37c66 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

removed review-user-action-required label

added review-pending-level-1 label

This merge request affects 1 package:

• Generators/Herwig7_i

This merge request affects 2 files:

• Generators/Herwig7_i/Herwig7_i/PowhegLesHouchesFileReader.h
• Generators/Herwig7_i/src/PowhegLesHouchesFileReader.cxx

The system determined that CI tests (with names matching "^CITest_Trigger.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 94a37c66)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 56626]

added review-approved label and removed review-pending-level-1 label

Changes and CI look fine. Approving.

Kira (L1)

merged

mentioned in commit 9dfaeb1b

added sweep:ignore label