Add validator of L1 and HLT trigger decision to T0 such that any corruption in the trigger decision is spotted promptly.
We can enable this at T0 only after !55546 (merged) is deployed to P1. I will mark it as DRAFT up to this point.
In addition, the initial runs taken with 22.0.77 have bad isPrescaled bits, following from partial-fix !55464 (merged). Once we know which runs are affected, we should explicitly exclude them from this checker for future T0 processing. we need to restore the previous behaviour of having no isPrescaled bits instead of wrong isPrescaled bits. This MR now includes a small special reconstruction
ifstatement when processing data runs
429603, 429606, 429612, 429658, 429697, 429716`
Prior run 3 runs had no HLT isPrescaled
bit set and so will not be flagged as bad by this validator (i.e. it would not on its own have caught this problem, if it was available sooner).
The validation is put initially in WARNING mode, and then after a while we will transition it to ERROR mode.
Marking urgent as we will need T0 bulk (re)processing of the 6 above affected runs before trigger will be able to sign off on these.
Merge request reports
Activity
assigned to @tamartin
This merge request affects 1 package:
- Trigger/TrigAnalysis/TrigDecisionMaker
This merge request affects 4 files:
- Trigger/TrigAnalysis/TrigDecisionMaker/python/TrigDecisionMakerConfig.py
- Trigger/TrigAnalysis/TrigDecisionMaker/src/TrigDecisionMakerValidator.cxx
- Trigger/TrigAnalysis/TrigDecisionMaker/src/TrigDecisionMakerValidator.h
- Trigger/TrigAnalysis/TrigDecisionMaker/src/components/TrigDecisionMaker_entries.cxx
Adding @tamartin as watcher
CI Result SUCCESS (hash cfbe59b5)Athena DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 56804]added 1 commit
- 410158e7 - Apply special run protection to T0 trigger reco to deal with affected runs...
added urgent label
This merge request affects 1 package:
- Trigger/TrigAnalysis/TrigDecisionMaker
This merge request affects 5 files:
- Trigger/TrigAnalysis/TrigDecisionMaker/python/TrigDecisionMakerConfig.py
- Trigger/TrigAnalysis/TrigDecisionMaker/src/TrigDecisionMakerMT.cxx
- Trigger/TrigAnalysis/TrigDecisionMaker/src/TrigDecisionMakerValidator.cxx
- Trigger/TrigAnalysis/TrigDecisionMaker/src/TrigDecisionMakerValidator.h
- Trigger/TrigAnalysis/TrigDecisionMaker/src/components/TrigDecisionMaker_entries.cxx
Adding @tamartin as watcher
added review-pending-level-1 label
CI Result SUCCESS (hash 410158e7)Athena DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 56839]added review-approved label and removed review-pending-level-1 label
added review-approved-tier0 label
added review-approved-point1 label
mentioned in commit b96b2e6e