Revert element link creation for trigger matching

While migrating the DF trigger matching tool to use ReadHandles I inadvertently switched to using the handle's hashed key (which hashes using the CLID for xAOD::IParticleContainer) from letting the link read it from the event store (which then hashes with the correct CLID). This apparently makes these links unreadable in AnalysisBase. The fix is to give the link the std::string key which it then uses to figure out the correct hash behind the scenes.

This should close ATR-26071

assigned to @jburr

This merge request affects 1 package:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkTrigger

This merge request affects 1 file:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkTrigger/src/TriggerMatchingTool.cxx

Adding @tamartin as watcher

added Derivation Trigger master review-pending-level-1 labels

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 63c71f37)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 56838]

Approved
Albert (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit fbfe909a

added sweep:ignore label