small correction to Run3 FCS Muon Punch Through developments

Small correction that should have been included in !54822 (merged)

Remove calo boundary check inside PunchThroughTools. Check is not necessary and does not work as intended.

added 21.0 Simulation labels

requested review from @jchapman and @tlari

assigned to @thcarter

marked this merge request as ready

requested review from @mfauccig

requested review from @cyoung

Tested with 250 Zprime events and 10k single pion events

This merge request affects 1 package:

• Simulation/ISF/ISF_FastCaloSim/ISF_PunchThroughTools

This merge request affects 1 file:

• Simulation/ISF/ISF_FastCaloSim/ISF_PunchThroughTools/src/PunchThroughTool.cxx

Adding @jchapman ,@pjacka ,@mfauccig ,@ahasib ,@schaarsc ,@tadej ,@xiaozhon as watchers

added review-pending-level-1 label

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

added urgent label

marked this merge request as draft

marked this merge request as ready

CI Result SUCCESS (hash 6db025e9)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 167
AthDataQuality: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 7
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 56843]

The compile warnings seem to be unrelated; given the urgent label I think I can approve now rather than wait for the CI to rerun.
Albert (L1)

added review-approved label and removed review-pending-level-1 label

Hi @jmaurer @pberta,

Sorry to ask again, but could a release of 21.0 be built when this gets merged? This is just a small correction that should have been included in !54822 (merged)

Thanks, Tom

ok, sure

Thanks!

hi, building release 21.0.135 will take some more time as I accidentally messed up the installation area by not using the correct nightly right away. Now I've been waiting for external help to fix this, so I'm not sure how long it will take, sorry. Do you have an urgent need for that release?

Hi @jmaurer,

No problem, i requested the release to run some physics validation on. But we have been able to submit the jobs with the nightly instead.

Thanks, Tom

ok, good, thanks

resolved all threads

resolved all threads