23.0-cppcheck-ForwardRegionMgField

Solve or suppress (for false positive) last remaining cppcheck defects in the error, warning and portability categories for /ForwardDetectors path. Solved a few performance ones along the way (string should be passed as const ref) and tidied up some headers.

assigned to @sroe

This merge request affects 3 packages:

• ForwardDetectors/ForwardSimulation/ForwardRegionMgField
• ForwardDetectors/ForwardTracker
• ForwardDetectors/ZDC/ZdcAnalysis

Affected files list will not be printed in this case

Adding @jchapman as watcher

added ForwardDetectors analysis-review-required master review-pending-level-1 labels

CI Result SUCCESS (hash 96a4b0b7)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 56945]

Looks good, approving
Albert (L1)

added review-approved label and removed review-pending-level-1 label

added analysis-review-approved label and removed analysis-review-required label

merged

mentioned in commit c3683f1b

added sweep:ignore label