Remove sTGC hits with negative calibrated charge
sTGC calibrated charge in data may become negative due to the lack of proper calibration constants. The negative charges are removed to prevent errors downstream. They represent a small fraction of hits that have low deposited energy, so discarding them would have a negligible impact. With proper calibration, all charge values should be positive.
This merge request targets ATLASRECTS-714, restoring some changes by @sangelid to protect against corrupted data !55062 (closed). Tagging also @pscholer, @jojungge, @rosati
Merge request reports
Activity
assigned to @chchau
added 22.0 MuonSpectrometer review-pending-level-1 labels
Athena DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
added frozen-tier0-violating label
I am confused by the description and statements. The original description says the issue is some hits have -ve charge and that should not be used. It also says the cause is a lack of proper calibration. Then @jojungge says the information is garbage, but that sounds quite different from not properly calibrated. Or are there are two different issues being solved here?
For the calibration issue would we eventually have a proper calibration that means we will never see these -ve charge hits?
Unless its super urgent, we could discuss this with everyone in next weeks RIG.
Cheers,
Mark
Edited by Mark Hodgkinson- Resolved by Julien Maurer
Not properly calibrated is a synonym for complete garbage. Anyhow, these NSW hits need to be removed from the reconstruction. I'd rather push for merging asap.
-
Athena DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
added review-user-action-required label
mentioned in merge request !55126 (closed)
removed review-user-action-required label
The conversion between charge and ADC counts is linear. The hits with low ADC counts (some have zero count) are shifted to the negative region. I looked at some data files that include sTGC. The part in the negative region is a small fraction and looks like noise, as shown below. So it is likely garbage. The detector is being commissioned, therefore the calibration that should be done per readout channel is not yet available.
Hi, just to confirm that is fine to remove hits with negative charge (caused by temporarily improper calibration as normal with a detector being commissioned): this modification will cause no relevant change in the reconstruction, as we already discussed in the NSW community. In any case hits with negative charge should not be used in the reco, the negligible fraction that we have now is coming, as Chav already wrote, from temporary calibrations (so it is not exactly garbage but we should not use them in the reconstruction if not yet properly calibrated). thanks, cheers, Stefano
-
Athena DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
removed review-pending-level-1 label
added review-approved label
added review-approved-point1 label
mentioned in commit 5438a883
