EventSelector: notice if Inputs changed in an EOF incident ATEAM-842

Yet another fix for EventSelectorAthenaPool to handle correctly updates of the InputCollections property - this time cover the case when the update is done from inside EndInputFile incident handler (VP1 EventDisplay case)

assigned to @mnowak

added full-unit-tests label

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

This merge request affects 1 package:

• Database/AthenaPOOL/EventSelectorAthenaPool

This merge request affects 1 file:

• Database/AthenaPOOL/EventSelectorAthenaPool/src/EventSelectorAthenaPool.cxx

Adding @tadej ,@mnowak ,@ssnyder as watchers

added 22.0 Database review-pending-level-1 labels

CI Result FAILURE (hash 160bf3e9)

	Athena	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 57009]

Jenkins please retry a build

This merge request affects 1 package:

• Database/AthenaPOOL/EventSelectorAthenaPool

This merge request affects 1 file:

• Database/AthenaPOOL/EventSelectorAthenaPool/src/EventSelectorAthenaPool.cxx

Adding @tadej ,@mnowak ,@ssnyder as watchers

Note that the failing unit test ISF_FastCaloSimServicesTest is also failing in the nightly:
https://bigpanda.cern.ch/testsview/?nightly=22.0_Athena_x86_64-centos7-gcc11-opt&rel=2022-08-04T2101&ar=x86_64-centos7-gcc11-opt&proj=Athena

CI Result FAILURE (hash 160bf3e9)

	Athena	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 57033]

Right, the same test failing - unrelated to this MR. Please proceed with the review :)
Cheers, Marcin

Agreed, the CI failure is unrelated. The changes look fine. Approving.

Jason (L1)

added review-approved label and removed review-pending-level-1 label

we can re-run the CI pipeline after !55706 (merged) is merged later today.

Jenkins please retry a build

This merge request affects 1 package:

• Database/AthenaPOOL/EventSelectorAthenaPool

This merge request affects 1 file:

• Database/AthenaPOOL/EventSelectorAthenaPool/src/EventSelectorAthenaPool.cxx

Adding @tadej ,@mnowak ,@ssnyder as watchers

added review-pending-level-1 label and removed review-approved label

CI Result SUCCESS (hash 160bf3e9)

	Athena	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 57099]

adding back the approved review labels

removed review-pending-level-1 label

added review-approved label

added review-approved-tier0 label

added review-approved-point1 label

merged

mentioned in commit 1bce98d3