Remapping of VMM IDs captured by the ROC to their IDs in the standard mapping.

The vmm ids captured by the ReadOut Controller are not in accordance to the defined vmm channel mapping used everywhere else (related Jira Ticket: ATLNSWDAQ-74). Because of this, the vmm/vmm channel association to the physical channel index in currently not correct.

To query the map for a strip index, we must first remap the vmm id that is parsed from the ROB fragment to the id of that same vmm has in the defined map.

Tagging @rowang, @rosati, @iodice, @stavrop.

requested review from @jojungge and @epasqual

assigned to @sangelid

This merge request affects 1 package:

• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode

This merge request affects 3 files:

• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode/MuonNSWCommonDecode/NSWOfflineHelper.h
• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode/MuonNSWCommonDecode/VMMChannel.h
• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode/MuonNSWCommonDecode/sTGCMapper.h

Adding @rosati ,@wleight ,@stavrop ,@jojungge ,@apsallid ,@pscholer as watchers

added 22.0 MuonSpectrometer review-pending-level-1 labels

changed the description

removed 22.0 MuonSpectrometer review-pending-level-1 labels

added frozen-tier0-violating label

added 22.0 MuonSpectrometer bugfix review-pending-level-1 urgent labels

Tagging: @elmsheus, @nstyles, @mhodgkin, @goetz, @pberta, @jmaurer, @tamartin as this MR violates the frozen-tier0-violating policy and is super duper urgent needed.

The current mapping employed in Athena is pure and will not give us any sTGC hit on track. The MR should be accepted asap.

Tagging: @gabarone, @mvanadia to feed curiosity

Another episode of the philosopher of the day

Munich has a famous saloon named after him. It's quite proud of a particular tradition

added 1 deleted label

Hi, sorry just to complete the information and slightly rephrasing: the current mapping in athena is the nominal (i.e. by design) STGC cabling, i.e. in principle it would have been fully correct. But, the analysis of the first data collected in the past days allowed to discover the issue in the real detector cabling, that is addessed by this re-mapping MR.

So this change, which is indeed to be labeled as urgent, is motivated by checks on the first data and it could have not been done earlier. It also needed cross checks with the detector and the DAQ group ( of a detector that is new in ATLAS ), that have been done.

Thanks, cheers, Stefano

CI Result SUCCESS (hash 9e92ded4)

	Athena	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 57046]

Approving - L1

removed review-pending-level-1 label

added review-approved label

resolved all threads

added 1 deleted label

removed 1 deleted label

Hi all,

just wanted to ask about the progress of this MR ? It's fixing the STGC mapping, so it will for sure change the output of the reco, but it's a needed change. NSW ( that the STGC is part of ) in the commissioning phase, the data collected up to now are only those from a small subset of the sectors, taken for commissioning. Is a discussion about it needed ?

thanks, cheers, Stefano

hi @jmaurer, ok thanks. In principle the STGC never entered in the reconstruction yet, it's a pure readout mapping fix, whose effect is really macroscopic. Also, at the moment they are really in the commissioning phase, we only have a handful of STGC sectors in the runs for debugging, and not even for all the runs or all of their length. So while this change is not impacting the reconstruction, it's very important for the commissioning. cheers, Stefano

resolved all threads

added review-approved-point1 label

resolved all threads

resolved all threads

mentioned in commit ec16e03c

merged