Skip to content
Snippets Groups Projects

HGTD hits time compatibility check

Merged Valentina Raskina requested to merge atlas-hgtd/athena:HGTD_reco_track_summary into master
All threads resolved!

Added a time compatibility check (algorithm TrackQualityCheckAlg ) among all the hits per track in HGTD, put the handles to all the decorations in TrackQualityCheckAlg . @aleopold

Edited by Valentina Raskina

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Valentina Raskina mentioned in merge request !55837 (merged)

    mentioned in merge request !55837 (merged)

  • added 3 commits

    • a7622d47 - changed decos naming
    • 6787cf43 - followed up the review for MR
    • 2d432756 - added the check for the last hit in ITk

    Compare with previous version

  • Note that this one now has conflicts.

  • Valentina Raskina added 1393 commits

    added 1393 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • c64ac4b4 - added a tool for the holes on track search in ITk

    Compare with previous version

  • added 2 commits

    • 4c3dabf5 - Revert "added a tool for the holes on track search in ITk"
    • aff07520 - Revert "added holes search in ITk"

    Compare with previous version

  • Valentina Raskina added 642 commits

    added 642 commits

    • aff07520...73711512 - 640 commits from branch atlas:master
    • a8b9f0e8 - ahite space change
    • d2eba70a - Merge remote-tracking branch 'upstream/master' into HGTD_reco_track_summary

    Compare with previous version

  • HI @vraskina, looks like your fork is set to Private, could you set it to Internal instead ? So that it does not appear on shifter's console. David as LVL2 gitmerge shifter

  • Valentina Raskina added 1691 commits

    added 1691 commits

    • d2eba70a...157a8011 - 1690 commits from branch atlas:master
    • db7c3365 - Merge remote-tracking branch 'upstream/master' into HGTD_reco_track_summary

    Compare with previous version

  • Valentina Raskina added 626 commits

    added 626 commits

    • db7c3365...70a55d3a - 624 commits from branch atlas:master
    • b351db6a - added decoration for the truth info of the time compatible hits
    • 70823bcf - Merge remote-tracking branch 'upstream/master' into HGTD_reco_track_summary

    Compare with previous version

  • Valentina Raskina added 835 commits

    added 835 commits

    • 70823bcf...21850b02 - 832 commits from branch atlas:master
    • 03e3da48 - added hit truth info to the decorations; changed the name of algo to be more general
    • f1f1128e - Merge remote-tracking branch 'upstream/master' into HGTD_reco_track_summary
    • 83297af2 - commented the .py files, so the modifications in TrackQualityCheckAlg are not...

    Compare with previous version

  • added 1 commit

    • 5c8043c7 - follow up on the review comments

    Compare with previous version

  • added 1 commit

    • 5c87a82a - removed the TrackQualityCheckAlg from python scripts

    Compare with previous version

  • Valentina Raskina marked this merge request as ready

    marked this merge request as ready

  • Valentina Raskina resolved all threads

    resolved all threads

  • This merge request affects 1 package:

    • HighGranularityTimingDetector/HGTD_Reconstruction/HGTD_RecAlgs

    This merge request affects 3 files:

    • HighGranularityTimingDetector/HGTD_Reconstruction/HGTD_RecAlgs/HGTD_RecAlgs/TrackQualityCheckAlg.h
    • HighGranularityTimingDetector/HGTD_Reconstruction/HGTD_RecAlgs/src/TrackQualityCheckAlg.cxx
    • HighGranularityTimingDetector/HGTD_Reconstruction/HGTD_RecAlgs/src/components/HGTD_RecAlgs_entries.cxx

    Adding @goetz ,@dshope ,@cohm ,@lshan as watchers

  • Valentina Raskina changed the description

    changed the description

  • :white_check_mark: CI Result SUCCESS (hash 5c87a82a)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 61871]

  • mentioned in commit 85f047fc

  • Please register or sign in to reply
    Loading