Make FileMetaData accumulate Lumi and Run Numbers from inputs ATLASG-1651
The new type of in-file metadata - FileMetaData - was copying metadata from the first input file and ignoring others. This made SharedWriter lose information about lumiblocks (and possibly runnumbers) from all clients except the first one. It was also printing warnings about inconsistent metadata. They will be gone now if the difference is only in lumiblocks and runnumbers.
Merge request reports
Activity
assigned to @mnowak
added full-integration-tests label
Hi @gemmeren - I would like to add you for approval, but I can't find any buttons for that...
Cheers, MarcinThis merge request affects 2 packages:
- Event/xAOD/xAODMetaData
- Event/xAOD/xAODMetaDataCnv
Affected files list will not be printed in this case
Adding @akraszna as watcher
added 22.0 EDM review-pending-level-1 labels
- Resolved by Marcin Nowak
Hi @mnowak,
thanks a lot for opening this MR! However, shouldn't it target master as well given derivations are run in Athena/master?
Cheers, Cristiano
requested review from @gemmeren
added urgent label
CI Result SUCCESS (hash dcd19138)Athena DetCommon externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 57117]added review-approved label and removed review-pending-level-1 label
added review-approved-point1 label
mentioned in commit f1b9ac21
Hi James,
I think this MR was just swept into master: commit
there were some problems with the sweep yesterday.