Manual sweep for !55563 to 22.0: b-tagging code cleanup

This is just cherry picking @rjoshi's MR that cleaned up the b-tagging code a bit.

Unfortunately OldFlags2NewFlags has already diverged quite a lot between the releases so this created a conflict.

assigned to @dguest

changed title from Moved the lines of b-tagging code that replace or append strings to the top (cherry pick !55563) to Cherry pick !55563: Moved the lines of b-tagging code that replace or append strings to the top.

changed title from Cherry pick !55563 (merged): Moved the lines of b-tagging code that replace or append strings to the top. to Cherry pick !55563 (merged) to 22.0: b-tagging code cleanup

changed title from Cherry pick !55563 (merged) to 22.0: b-tagging code cleanup to Manual sweep for !55563 (merged) to 22.0: b-tagging code cleanup

This merge request affects 5 packages:

• PhysicsAnalysis/AnalysisCommon/ParticleJetTools
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkFlavourTag
• PhysicsAnalysis/JetTagging/JetTagAlgs/BTagging
• PhysicsAnalysis/JetTagging/JetTagConfig
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@nishu ,@rcreager ,@duperrin ,@sanmay ,@jveatch ,@bernius ,@suyogs ,@dguest ,@sekula ,@bdong ,@lidiaz as watchers

added 22.0 Analysis BTagging Derivation JetEtmiss Trigger TriggerMenu review-pending-level-1 labels

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

added Run2-DataReco-output-changed Run3-MCReco-output-changed labels

CI Result FAILURE (hash 341d0bc3)

	Athena	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 57118]

Jenkins please retry a build

@rjoshi this is sort of weird, I don't understand why the output is changing in the Athena tests but I thought we'd run the same ones in the merge to master...

This merge request affects 5 packages:

• PhysicsAnalysis/AnalysisCommon/ParticleJetTools
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkFlavourTag
• PhysicsAnalysis/JetTagging/JetTagAlgs/BTagging
• PhysicsAnalysis/JetTagging/JetTagConfig
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@nishu ,@rcreager ,@duperrin ,@sanmay ,@jveatch ,@bernius ,@suyogs ,@dguest ,@sekula ,@bdong ,@lidiaz as watchers

Hi @dguest we did run the same CI tests for the master branch and they all passed it. This seems to have something to do with Frozen tier 0 policy? I can try looking at this tomorrow. I don't understand what these references are or what they mean and how they are compared with the output from CI tests.

ERROR    Py:diff-root         INFO  [xAOD::BTaggingAuxContainer_v2_BTagging_AntiKt4EMPFlowAuxDyn.DL1dv00_pb]: 39 leaves differ
ERROR    Py:diff-root         INFO  [xAOD::BTaggingAuxContainer_v2_BTagging_AntiKt4EMPFlowAuxDyn.DL1dv00_pc]: 39 leaves differ
ERROR    Py:diff-root         INFO  [xAOD::BTaggingAuxContainer_v2_BTagging_AntiKt4EMPFlowAuxDyn.DL1dv00_pu]: 39 leaves differ
ERROR    Your change breaks the frozen tier0 policy in test q442.

added 1 commit

• 0c58fa1a - I don't know why this worked before...

Compare with previous version

added 1 deleted label

This merge request affects 5 packages:

• PhysicsAnalysis/AnalysisCommon/ParticleJetTools
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkFlavourTag
• PhysicsAnalysis/JetTagging/JetTagAlgs/BTagging
• PhysicsAnalysis/JetTagging/JetTagConfig
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@nishu ,@rcreager ,@duperrin ,@sanmay ,@jveatch ,@bernius ,@suyogs ,@dguest ,@sekula ,@bdong ,@lidiaz as watchers

CI Result FAILURE (hash 341d0bc3)

	Athena	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 57125]

CI Result FAILURE (hash 0c58fa1a)

	Athena	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 57130]

added 1 commit

• 945075af - Add jet collection name without suffix in hope that it fixes one of the CI...

Compare with previous version

This merge request affects 5 packages:

• PhysicsAnalysis/AnalysisCommon/ParticleJetTools
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkFlavourTag
• PhysicsAnalysis/JetTagging/JetTagAlgs/BTagging
• PhysicsAnalysis/JetTagging/JetTagConfig
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@nishu ,@rcreager ,@duperrin ,@sanmay ,@jveatch ,@bernius ,@suyogs ,@dguest ,@sekula ,@bdong ,@lidiaz as watchers

CI Result FAILURE (hash 945075af)

	Athena	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 57172]

Jenkins please retry a build

This merge request affects 5 packages:

• PhysicsAnalysis/AnalysisCommon/ParticleJetTools
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkFlavourTag
• PhysicsAnalysis/JetTagging/JetTagAlgs/BTagging
• PhysicsAnalysis/JetTagging/JetTagConfig
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @sutt ,@nishu ,@rcreager ,@duperrin ,@sanmay ,@jveatch ,@bernius ,@suyogs ,@dguest ,@sekula ,@bdong ,@lidiaz as watchers

CI Result SUCCESS (hash 945075af)

	Athena	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 57181]

I'm removing all the "reco output changed" flags since it looks like Roshan's latest fix fixed it.

removed Run2-DataReco-output-changed Run3-MCReco-output-changed labels

@rjoshi I guess this should make the code here identical to that in master after !55748 (merged), right? Assuming so, we should probably mark that one as an urgent bugfix so it goes in before someone makes a derivation without it.

mentioned in merge request !55748 (merged)

Yes, after 55748 is merged, the code will be identical for both 22.0 and master, assuming this MR gets merged as well. I have marked that MR as urgent and bugfix.

resolved all threads

lgtm approving -- L1

added review-approved label and removed review-pending-level-1 label

added review-approved-tier0 label

added review-approved-point1 label

mentioned in commit 256f0b53

merged