TrigCost: Extend ROS Monitoring

Add new histograms requested in ATR-26131 (examples are available there):

• Monitor ROS
  • How many times ROB was requested for the ROS request
• Monitor Chain
  • How many ROBs were requested for ROS request
  • How many times data was requested for ROS per event
  • How many ROBs were requested for ROS per event

To simplify sharing the data related to ROS requests (for example ROS-ROB mapping, ROS to bin mapping) a class was added, mimicking CostData. It is created once, in the initialization of the TrigCostAnalysis algorithm, and then, via CostData passed to monitors - this way the mappings won't be recalculated many times per event.

Some of the histograms are actually TProfile type - handling it was also added to the classes of the Cost Analysis.

Tagging @tamartin

assigned to @aporeba

This merge request affects 1 package:

• Trigger/TrigCost/TrigCostAnalysis

This merge request affects 18 files:

• Trigger/TrigCost/TrigCostAnalysis/src/CostData.cxx
• Trigger/TrigCost/TrigCostAnalysis/src/CostData.h
• Trigger/TrigCost/TrigCostAnalysis/src/CostROSData.cxx
• Trigger/TrigCost/TrigCostAnalysis/src/CostROSData.h
• Trigger/TrigCost/TrigCostAnalysis/src/CounterBase.cxx
• Trigger/TrigCost/TrigCostAnalysis/src/CounterBase.h
• Trigger/TrigCost/TrigCostAnalysis/src/TrigCostAnalysis.cxx
• Trigger/TrigCost/TrigCostAnalysis/src/TrigCostAnalysis.h
• Trigger/TrigCost/TrigCostAnalysis/src/Variable.cxx
• Trigger/TrigCost/TrigCostAnalysis/src/Variable.h
• Trigger/TrigCost/TrigCostAnalysis/src/counters/CounterChain.cxx
• Trigger/TrigCost/TrigCostAnalysis/src/counters/CounterChain.h
• Trigger/TrigCost/TrigCostAnalysis/src/counters/CounterROS.cxx
• Trigger/TrigCost/TrigCostAnalysis/src/counters/CounterROS.h
• Trigger/TrigCost/TrigCostAnalysis/src/monitors/MonitorChain.cxx
• Trigger/TrigCost/TrigCostAnalysis/src/monitors/MonitorChain.h
• Trigger/TrigCost/TrigCostAnalysis/src/monitors/MonitorROS.cxx
• Trigger/TrigCost/TrigCostAnalysis/src/monitors/MonitorROS.h

Adding @tamartin ,@aporeba as watchers

added 22.0 Trigger review-pending-level-1 labels

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result FAILURE (hash 738e1a65)

	Athena	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 57168]

Jenkins please retry a build

This merge request affects 1 package:

• Trigger/TrigCost/TrigCostAnalysis

This merge request affects 18 files:

• Trigger/TrigCost/TrigCostAnalysis/src/CostData.cxx
• Trigger/TrigCost/TrigCostAnalysis/src/CostData.h
• Trigger/TrigCost/TrigCostAnalysis/src/CostROSData.cxx
• Trigger/TrigCost/TrigCostAnalysis/src/CostROSData.h
• Trigger/TrigCost/TrigCostAnalysis/src/CounterBase.cxx
• Trigger/TrigCost/TrigCostAnalysis/src/CounterBase.h
• Trigger/TrigCost/TrigCostAnalysis/src/TrigCostAnalysis.cxx
• Trigger/TrigCost/TrigCostAnalysis/src/TrigCostAnalysis.h
• Trigger/TrigCost/TrigCostAnalysis/src/Variable.cxx
• Trigger/TrigCost/TrigCostAnalysis/src/Variable.h
• Trigger/TrigCost/TrigCostAnalysis/src/counters/CounterChain.cxx
• Trigger/TrigCost/TrigCostAnalysis/src/counters/CounterChain.h
• Trigger/TrigCost/TrigCostAnalysis/src/counters/CounterROS.cxx
• Trigger/TrigCost/TrigCostAnalysis/src/counters/CounterROS.h
• Trigger/TrigCost/TrigCostAnalysis/src/monitors/MonitorChain.cxx
• Trigger/TrigCost/TrigCostAnalysis/src/monitors/MonitorChain.h
• Trigger/TrigCost/TrigCostAnalysis/src/monitors/MonitorROS.cxx
• Trigger/TrigCost/TrigCostAnalysis/src/monitors/MonitorROS.h

Adding @tamartin ,@aporeba as watchers

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash 738e1a65)

	Athena	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 57199]

I think this is ok, but will pass to L2 for a second look
Albert (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

added review-approved label and removed review-pending-level-2 label

Looks good. Karolos (L2)

added review-approved-tier0 label

added review-approved-point1 label

mentioned in commit 21210a87

merged